Remove Nested Message Loop from MenuController

All menus on aura platforms no longer use the nested message loop code path of MenuController.

On Mac non-native menus also no longer use the nested message loop. While native menus are handled vis menu_runner_impl_cocoa, which does block.

This change removes the Nested Message Loop code paths from MenuController. 

Additionally some tests which specifically were for nested message loops below asynchronous menus, have been either transitioned, or removed if redundant.

TEST=views_unittests, manual testing.
BUG=557130
Review-Url: https://codereview.chromium.org/2779373002
Cr-Commit-Position: refs/heads/master@{#460818}
Committed: https://chromium.googlesource.com/chromium/src/+/b31c887a2d14761b078f329629f1d3469106b891

[jonross, 2017-03-29 22:00:00]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 22:00:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jonross, 2017-03-29 22:57:55]

Patchset #1 (id:1) has been deleted

[jonross, 2017-03-29 23:01:44]

Description was changed from

==========
Remove Nested Message Loop from MenuController

BUG=557130
==========

to

==========
All menus on aura platforms no longer use the nested message loop code path of
MenuController.

On Mac non-native menus also no longer use the nested message loop. While native
menus are handled vis menu_runner_impl_cocoa, which does block.

This change removes the Nested Message Loop code paths from MenuController. 

Additionally some tests which specifically were for nested message loops below
asynchronous menus, have been either transitioned, or removed if redundant.

TEST=views_unittests, manual testing.
BUG=557130
==========

[jonross, 2017-03-29 23:02:15]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-03-29 23:02:15]

Hey sky@,

In this change I removed the nested message loop code path within
MenuController.

Could you PTAL?

Thanks,
Jon

[sky, 2017-03-29 23:52:26]

Yay! LGTM

[commit-bot: I haz the power, 2017-03-30 00:55:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 00:55:32]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jonross, 2017-03-30 13:35:54]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-03-30 13:36:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 16:00:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:00:52]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jonross, 2017-03-30 16:04:58]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:05:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 17:52:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490889898218610,
"parent_rev": "087549eb773ef4b5fd43b5bd57f1a9ddfceeb486", "commit_rev":
"b31c887a2d14761b078f329629f1d3469106b891"}

[commit-bot: I haz the power, 2017-03-30 17:53:36]

Description was changed from

==========
All menus on aura platforms no longer use the nested message loop code path of
MenuController.

On Mac non-native menus also no longer use the nested message loop. While native
menus are handled vis menu_runner_impl_cocoa, which does block.

This change removes the Nested Message Loop code paths from MenuController. 

Additionally some tests which specifically were for nested message loops below
asynchronous menus, have been either transitioned, or removed if redundant.

TEST=views_unittests, manual testing.
BUG=557130
==========

to

==========
All menus on aura platforms no longer use the nested message loop code path of
MenuController.

On Mac non-native menus also no longer use the nested message loop. While native
menus are handled vis menu_runner_impl_cocoa, which does block.

This change removes the Nested Message Loop code paths from MenuController. 

Additionally some tests which specifically were for nested message loops below
asynchronous menus, have been either transitioned, or removed if redundant.

TEST=views_unittests, manual testing.
BUG=557130

Review-Url: https://codereview.chromium.org/2779373002
Cr-Commit-Position: refs/heads/master@{#460818}
Committed:
https://chromium.googlesource.com/chromium/src/+/b31c887a2d14761b078f329629f1...
==========

[commit-bot: I haz the power, 2017-03-30 17:53:37]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b31c887a2d14761b078f329629f1...