Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2779213004: Revert "Take desktop screenshots after test failures in test_runner.py." (Closed)

Created:
3 years, 8 months ago by smut
Modified:
3 years, 8 months ago
Reviewers:
baxley
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Take desktop screenshots after test failures in test_runner.py." This reverts commit 54548ddbe9febbe12dafb3178811a0c86b0636f7. Reason for revert: Likely to have caused a significant regression in net_unittests cycle time, which is producing a long pending queue on ios-simulator, which in turn is blocking the entire commit queue. BUG=706609 TBR=baxley Review-Url: https://codereview.chromium.org/2779213004 . Cr-Commit-Position: refs/heads/master@{#460567} Committed: https://chromium.googlesource.com/chromium/src/+/73bfc0e7d25c0f6f2c2c8320877434896d7434cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M ios/build/bots/scripts/test_runner.py View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
smut
3 years, 8 months ago (2017-03-29 23:07:53 UTC) #1
smut
Committed patchset #1 (id:1) manually as 73bfc0e7d25c0f6f2c2c8320877434896d7434cb.
3 years, 8 months ago (2017-03-29 23:08:32 UTC) #3
baxley
3 years, 8 months ago (2017-03-30 13:27:48 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698