Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: ios/build/bots/scripts/test_runner.py

Issue 2779213004: Revert "Take desktop screenshots after test failures in test_runner.py." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/build/bots/scripts/test_runner.py
diff --git a/ios/build/bots/scripts/test_runner.py b/ios/build/bots/scripts/test_runner.py
index 23d612487974feff00c7262ff0c643887d9ed18d..0449975a659e57736ed07c701bab49faf2e297c7 100644
--- a/ios/build/bots/scripts/test_runner.py
+++ b/ios/build/bots/scripts/test_runner.py
@@ -288,7 +288,6 @@ class TestRunner(object):
stderr=subprocess.STDOUT,
)
- failure_count = 0
while True:
line = proc.stdout.readline()
if not line:
@@ -298,16 +297,6 @@ class TestRunner(object):
print line
sys.stdout.flush()
- # If there is a new test failure, take a desktop screenshot.
- # parser.FailedTests() considers in progress tests as failed, so a check
- # is needed that the current test isn't included in the list of failed
- # tests.
- new_failure_count = len([test for test in parser.FailedTests()
- if test != parser.GetCurrentTest()])
- if (new_failure_count > failure_count):
- self.screenshot_desktop()
- failure_count = new_failure_count
-
proc.wait()
sys.stdout.flush()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698