Move CreateSocketPair to header file

Move CreateSocketPair to header file

Move function CreateSocketPair from base/posix/unix_domain_socket_linux.cc to
base/posix/unix_domain_socket_linux.h so it can be shared.

Review-Url: https://codereview.chromium.org/2779033002
Cr-Commit-Position: refs/heads/master@{#462350}
Committed: https://chromium.googlesource.com/chromium/src/+/6a52479520c587fc61eb3106f27ac6bd396fa736

[shunhsingou, 2017-04-05 03:34:42]

shunhsingou@chromium.org changed reviewers:
+ dcheng@chromium.org, lhchavez@chromium.org, mdempsky@chromium.org

[mdempsky, 2017-04-05 04:50:53]

https://codereview.chromium.org/2779033002/diff/1/base/posix/unix_domain_sock...
File base/posix/unix_domain_socket_linux.h (right):

https://codereview.chromium.org/2779033002/diff/1/base/posix/unix_domain_sock...
base/posix/unix_domain_socket_linux.h:26: bool CreateSocketPair(ScopedFD* one,
ScopedFD* two);
This should be BASE_EXPORT, or alternatively changed to a static member function
of UnixDomainSocket. In the latter case, I'd probably rename it to
CreateConnectedPair.

[shunhsingou, 2017-04-05 05:11:18]

https://codereview.chromium.org/2779033002/diff/1/base/posix/unix_domain_sock...
File base/posix/unix_domain_socket_linux.h (right):

https://codereview.chromium.org/2779033002/diff/1/base/posix/unix_domain_sock...
base/posix/unix_domain_socket_linux.h:26: bool CreateSocketPair(ScopedFD* one,
ScopedFD* two);
On 2017/04/05 04:50:53, mdempsky wrote:
> This should be BASE_EXPORT, or alternatively changed to a static member
function
> of UnixDomainSocket. In the latter case, I'd probably rename it to
> CreateConnectedPair.

Done.

[mdempsky, 2017-04-05 05:52:57]

lgtm (but base/OWNERS will have to approve)

[Luis Héctor Chávez, 2017-04-05 14:55:44]

lgtm with a nit (even though my vote here does not really count).

https://codereview.chromium.org/2779033002/diff/20001/base/posix/unix_domain_...
File base/posix/unix_domain_socket_linux.cc (right):

https://codereview.chromium.org/2779033002/diff/20001/base/posix/unix_domain_...
base/posix/unix_domain_socket_linux.cc:29: // Creates a connected pair of
UNIX-domain SOCK_SEQPACKET sockets, and passes
nit: You already have documentation in the .h. This one is redundant.

[dcheng, 2017-04-05 17:09:20]

LGTM

[shunhsingou, 2017-04-06 03:16:35]

https://codereview.chromium.org/2779033002/diff/20001/base/posix/unix_domain_...
File base/posix/unix_domain_socket_linux.cc (right):

https://codereview.chromium.org/2779033002/diff/20001/base/posix/unix_domain_...
base/posix/unix_domain_socket_linux.cc:29: // Creates a connected pair of
UNIX-domain SOCK_SEQPACKET sockets, and passes
On 2017/04/05 14:55:44, Luis Héctor Chávez wrote:
> nit: You already have documentation in the .h. This one is redundant.

Done.

[shunhsingou, 2017-04-06 03:17:06]

The CQ bit was checked by shunhsingou@chromium.org

[shunhsingou, 2017-04-06 03:17:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, dcheng@chromium.org, mdempsky@chromium.org
Link to the patchset: https://codereview.chromium.org/2779033002/#ps40001
(title: "Remove redundant comment")

[commit-bot: I haz the power, 2017-04-06 03:17:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 04:17:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491448626379940,
"parent_rev": "90b048661a3949cd38ef690052d6930c230b4100", "commit_rev":
"6a52479520c587fc61eb3106f27ac6bd396fa736"}

[commit-bot: I haz the power, 2017-04-06 04:18:01]

Description was changed from

==========
Move CreateSocketPair to header file

Move function CreateSocketPair from base/posix/unix_domain_socket_linux.cc to
base/posix/unix_domain_socket_linux.h so it can be shared.
==========

to

==========
Move CreateSocketPair to header file

Move function CreateSocketPair from base/posix/unix_domain_socket_linux.cc to
base/posix/unix_domain_socket_linux.h so it can be shared.

Review-Url: https://codereview.chromium.org/2779033002
Cr-Commit-Position: refs/heads/master@{#462350}
Committed:
https://chromium.googlesource.com/chromium/src/+/6a52479520c587fc61eb3106f27a...
==========

[commit-bot: I haz the power, 2017-04-06 04:18:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6a52479520c587fc61eb3106f27a...