Move CreateSocketPair to header file

base/posix/unix_domain_socket_linux.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/posix/unix_domain_socket_linux.h"
 
 #include <errno.h>
 #include <sys/socket.h>
 #include <unistd.h>
 
 #include <vector>
 
 #include "base/files/scoped_file.h"
 #include "base/logging.h"
 #include "base/pickle.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/stl_util.h"
 #include "build/build_config.h"
 
 #if !defined(OS_NACL_NONSFI)
 #include <sys/uio.h>
 #endif
 
 namespace base {
 
 const size_t UnixDomainSocket::kMaxFileDescriptors = 16;
 
 #if !defined(OS_NACL_NONSFI)
 // Creates a connected pair of UNIX-domain SOCK_SEQPACKET sockets, and passes

[Luis Héctor Chávez, 2017/04/05 14:55:44]

nit: You already have documentation in the .h. This one is redundant.

[shunhsingou, 2017/04/06 03:16:35]

Done.

 // ownership of the newly allocated file descriptors to |one| and |two|.
 // Returns true on success.
-static bool CreateSocketPair(ScopedFD* one, ScopedFD* two) {
+bool CreateSocketPair(ScopedFD* one, ScopedFD* two) {
   int raw_socks[2];
   if (socketpair(AF_UNIX, SOCK_SEQPACKET, 0, raw_socks) == -1)
     return false;
   one->reset(raw_socks[0]);
   two->reset(raw_socks[1]);
   return true;
 }
 
 // static
 bool UnixDomainSocket::EnableReceiveProcessId(int fd) {
@@ skipping 193 matching lines @@
   }
 
   if (result_fd)
     *result_fd = recv_fds.empty() ? -1 : recv_fds[0].release();
 
   return reply_len;
 }
 #endif  // !defined(OS_NACL_NONSFI)
 
 }  // namespace base