Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2778943002: Pass HttpServerProperties in to QuicHttpStream so that it can mark QUIC broken. (Closed)

Created:
3 years, 9 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Buck
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass HttpServerProperties in to QuicHttpStream so that it can mark QUIC broken. Review-Url: https://codereview.chromium.org/2778943002 Cr-Commit-Position: refs/heads/master@{#460523} Committed: https://chromium.googlesource.com/chromium/src/+/1d3b31ac05e4a8c0912cdf39de5a19efffb672de

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -128 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 3 chunks +11 lines, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 5 chunks +14 lines, -7 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 112 chunks +112 lines, -112 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
Ryan Hamilton
Even this CL doesn't actually do anything, I'm sending it out now to make follow ...
3 years, 9 months ago (2017-03-27 22:29:30 UTC) #2
Buck
lgtm
3 years, 8 months ago (2017-03-28 21:01:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778943002/20001
3 years, 8 months ago (2017-03-29 19:06:42 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:35:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d3b31ac05e4a8c0912cdf39de5a...

Powered by Google App Engine
This is Rietveld 408576698