Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2777333002: Simplify the the logic for setting the final response status for a (Closed)

Created:
3 years, 9 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Buck
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify the the logic for setting the final response status for a QUIC HTTP stream, by centralizing the logic into a single method. Review-Url: https://codereview.chromium.org/2777333002 Cr-Commit-Position: refs/heads/master@{#460590} Committed: https://chromium.googlesource.com/chromium/src/+/4cbd5e215ed47201e8914cb93269051eaf41fc96

Patch Set 1 #

Total comments: 8

Patch Set 2 : comments #

Patch Set 3 : Fix #

Patch Set 4 : Rebase #

Patch Set 5 : Closer to old code #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -41 lines) Patch
M net/quic/chromium/quic_http_stream.h View 1 2 3 4 5 3 chunks +15 lines, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 2 3 4 5 18 chunks +74 lines, -40 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (12 generated)
Ryan Hamilton
3 years, 9 months ago (2017-03-27 21:57:17 UTC) #2
Buck
https://codereview.chromium.org/2777333002/diff/1/net/quic/chromium/quic_http_stream.cc File net/quic/chromium/quic_http_stream.cc (right): https://codereview.chromium.org/2777333002/diff/1/net/quic/chromium/quic_http_stream.cc#newcode481 net/quic/chromium/quic_http_stream.cc:481: DoCallback(GetResponseStatus()); Why not use a cached result from the ...
3 years, 8 months ago (2017-03-28 21:19:57 UTC) #3
Ryan Hamilton
Thanks! https://codereview.chromium.org/2777333002/diff/1/net/quic/chromium/quic_http_stream.cc File net/quic/chromium/quic_http_stream.cc (right): https://codereview.chromium.org/2777333002/diff/1/net/quic/chromium/quic_http_stream.cc#newcode481 net/quic/chromium/quic_http_stream.cc:481: DoCallback(GetResponseStatus()); On 2017/03/28 21:19:57, Buck wrote: > Why ...
3 years, 8 months ago (2017-03-28 21:54:04 UTC) #4
Buck
lgtm
3 years, 8 months ago (2017-03-28 21:56:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777333002/40001
3 years, 8 months ago (2017-03-28 22:29:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777333002/100001
3 years, 8 months ago (2017-03-29 23:56:04 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 00:14:38 UTC) #19
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4cbd5e215ed47201e8914cb93269...

Powered by Google App Engine
This is Rietveld 408576698