Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2778863002: Introduce DisplayProvider for DisplayCompositor. (Closed)

Created:
3 years, 9 months ago by kylechar
Modified:
3 years, 8 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce DisplayProvider for DisplayCompositor. Different logic for creating cc::Displays is required depending on where DisplayCompositor is initialized. Add DisplayProvider interface to abstract this logic away and add MusDisplayProvider implementation. BUG=664547 Review-Url: https://codereview.chromium.org/2778863002 Cr-Commit-Position: refs/heads/master@{#460150} Committed: https://chromium.googlesource.com/chromium/src/+/9c1b2cf6351dc1eb740bce11c620f5566042e11f

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Delete extra task runner ref. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -112 lines) Patch
M services/ui/gpu/gpu_main.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/gpu/gpu_main.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M services/ui/surfaces/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/surfaces/display_compositor.h View 1 2 4 chunks +7 lines, -36 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 1 2 3 chunks +9 lines, -73 lines 0 comments Download
A services/ui/surfaces/display_provider.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A services/ui/surfaces/mus_display_provider.h View 1 chunk +52 lines, -0 lines 0 comments Download
A services/ui/surfaces/mus_display_provider.cc View 1 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
kylechar
3 years, 9 months ago (2017-03-27 19:52:55 UTC) #2
Fady Samuel
lgtm
3 years, 9 months ago (2017-03-27 21:25:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778863002/40001
3 years, 8 months ago (2017-03-28 13:23:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/259155)
3 years, 8 months ago (2017-03-28 14:43:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778863002/40001
3 years, 8 months ago (2017-03-28 17:00:15 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:22:02 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9c1b2cf6351dc1eb740bce11c620...

Powered by Google App Engine
This is Rietveld 408576698