Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 2778843003: Revert of [pdf] Enable the Skia Path code in Chrome (Closed)

Created:
3 years, 8 months ago by dsinclair
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [pdf] Enable the Skia Path code in Chrome (patchset #2 id:20001 of https://codereview.chromium.org/2766553003/ ) Reason for revert: Received several issues, reverting experiment. Original issue's description: > [pdf] Enable the Skia Path code in Chrome > > This Cl enables the PDFium code to use Skia to render paths instead of > Anti-Grain Geometry. > > BUG=pdfium:11 > > Review-Url: https://codereview.chromium.org/2766553003 > Cr-Commit-Position: refs/heads/master@{#458793} > Committed: https://chromium.googlesource.com/chromium/src/+/1ca395c8d57ebb90e54b84db946a37b4abae3aaa TBR=caryclark@google.com,thestig@chromium.org,tsepez@chromium.org,brettw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=pdfium:11 Review-Url: https://codereview.chromium.org/2778843003 Cr-Commit-Position: refs/heads/master@{#460160} Committed: https://chromium.googlesource.com/chromium/src/+/94a0a47011c54d22e7e64e0f7f9d62ce9e9e82d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build_overrides/pdfium.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dsinclair
Created Revert of [pdf] Enable the Skia Path code in Chrome
3 years, 8 months ago (2017-03-28 15:29:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778843003/1
3 years, 8 months ago (2017-03-28 15:29:54 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/392865)
3 years, 8 months ago (2017-03-28 16:15:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778843003/1
3 years, 8 months ago (2017-03-28 16:18:09 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:49:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/94a0a47011c54d22e7e64e0f7f9d...

Powered by Google App Engine
This is Rietveld 408576698