Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2766553003:
[pdf] Enable the Skia Path code in Chrome (Closed)
Description[pdf] Enable the Skia Path code in Chrome
This Cl enables the PDFium code to use Skia to render paths instead of
Anti-Grain Geometry.
BUG=pdfium:11
Review-Url: https://codereview.chromium.org/2766553003
Cr-Commit-Position: refs/heads/master@{#458793}
Committed: https://chromium.googlesource.com/chromium/src/+/1ca395c8d57ebb90e54b84db946a37b4abae3aaa
Patch Set 1 #Patch Set 2 : Rebase to master #
Messages
Total messages: 25 (13 generated)
dsinclair@chromium.org changed reviewers: + caryclark@google.com, thestig@chromium.org, tsepez@chromium.org
PTAL.
lgtm
lgtm
The CQ bit was checked by dsinclair@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
dsinclair@chromium.org changed reviewers: + brettw@chromium.org
brettw@ for build_override/OWNERS.
rs LGTM.
The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dsinclair@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org, tsepez@chromium.org, caryclark@google.com Link to the patchset: https://codereview.chromium.org/2766553003/#ps20001 (title: "Rebase to master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490204050217450,
"parent_rev": "fa29809ee94916e79cd5e25060cd03ed3b1bb46f", "commit_rev":
"97b665eef36dd0944abaf54d118bb9196e171425"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490204050217450,
"parent_rev": "072c71cc3f3ad34d3df695fbb5673fa577eaafba", "commit_rev":
"1ca395c8d57ebb90e54b84db946a37b4abae3aaa"}
Message was sent while issue was closed.
Description was changed from ========== [pdf] Enable the Skia Path code in Chrome This Cl enables the PDFium code to use Skia to render paths instead of Anti-Grain Geometry. BUG=pdfium:11 ========== to ========== [pdf] Enable the Skia Path code in Chrome This Cl enables the PDFium code to use Skia to render paths instead of Anti-Grain Geometry. BUG=pdfium:11 Review-Url: https://codereview.chromium.org/2766553003 Cr-Commit-Position: refs/heads/master@{#458793} Committed: https://chromium.googlesource.com/chromium/src/+/1ca395c8d57ebb90e54b84db946a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1ca395c8d57ebb90e54b84db946a...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2778843003/ by dsinclair@chromium.org. The reason for reverting is: Received several issues, reverting experiment..
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
