Add WindowPinType property on arua::Window

Add WindowPinType property on arua::Window

Add WindowPinType property on arua::Window. This property can be used
for requesting pinning a window instead of using ash::wm::PinWindow().

BUG=697586
Review-Url: https://codereview.chromium.org/2778733004
Cr-Commit-Position: refs/heads/master@{#461923}
Committed: https://chromium.googlesource.com/chromium/src/+/e52cb19f44be5e48c4e34189c2c3d7f3439a4160

[Peng, 2017-03-29 21:24:34]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 21:25:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 21:40:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 21:40:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Peng, 2017-03-30 14:10:15]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 14:10:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 15:06:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 15:06:47]

Dry run: This issue passed the CQ dry run.

[Peng, 2017-03-30 15:14:03]

Description was changed from

==========
PinWindow

BUG=
==========

to

==========
Add WindowPinType property on arua::Window

Add WindowPinType property on arua::Window. This property can be used
for requesting pinning a window instead of using ash::wm::PinWindow().

BUG=697586
==========

[Peng, 2017-03-30 15:15:20]

penghuang@chromium.org changed reviewers:
+ sky@chromium.org

[Peng, 2017-03-30 15:15:20]

Hi Scott, PTAL. Thanks.

[Peng, 2017-03-30 19:05:04]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 19:05:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-30 20:12:21]

https://codereview.chromium.org/2778733004/diff/80001/ui/views/widget/widget.h
File ui/views/widget/widget.h (right):

https://codereview.chromium.org/2778733004/diff/80001/ui/views/widget/widget....
ui/views/widget/widget.h:550: void Pin(bool trusted);
Pinning is specific to ChromeOS, so you shouldn't expose functions for it at the
Widget level. Instead set the property on the widget's nativeview, e.g. the
aura::Window.

[commit-bot: I haz the power, 2017-03-30 20:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 20:29:24]

Dry run: This issue passed the CQ dry run.

[Peng, 2017-03-30 21:10:11]

https://codereview.chromium.org/2778733004/diff/80001/ui/views/widget/widget.h
File ui/views/widget/widget.h (right):

https://codereview.chromium.org/2778733004/diff/80001/ui/views/widget/widget....
ui/views/widget/widget.h:550: void Pin(bool trusted);
On 2017/03/30 20:12:21, sky wrote:
> Pinning is specific to ChromeOS, so you shouldn't expose functions for it at
the
> Widget level. Instead set the property on the widget's nativeview, e.g. the
> aura::Window.

Done.

[sky, 2017-03-31 04:40:26]

https://codereview.chromium.org/2778733004/diff/100001/ui/aura/mus/property_c...
File ui/aura/mus/property_converter.cc (right):

https://codereview.chromium.org/2778733004/diff/100001/ui/aura/mus/property_c...
ui/aura/mus/property_converter.cc:99:
ui::mojom::WindowManager::kWindowPinType_Property,
When you move the classes out of views you'll need to move registration of this
to ash/mus/window_manager.cc and in exo where it creates MusClient. You'll
likely want to create a function that can do the additional registration, say in
ash/public/cpp/property_registration.cc (you'll need to create this). I think
you'll also need to mirror the property in exo. See
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/ash/chrome_brows...
for an example of what I mean.

[Peng, 2017-03-31 18:09:22]

https://codereview.chromium.org/2778733004/diff/100001/ui/aura/mus/property_c...
File ui/aura/mus/property_converter.cc (right):

https://codereview.chromium.org/2778733004/diff/100001/ui/aura/mus/property_c...
ui/aura/mus/property_converter.cc:99:
ui::mojom::WindowManager::kWindowPinType_Property,
On 2017/03/31 04:40:26, sky wrote:
> When you move the classes out of views you'll need to move registration of
this
> to ash/mus/window_manager.cc and in exo where it creates MusClient. You'll
> likely want to create a function that can do the additional registration, say
in
> ash/public/cpp/property_registration.cc (you'll need to create this). I think
> you'll also need to mirror the property in exo. See
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/ash/chrome_brows...
> for an example of what I mean.

Done.

[sky, 2017-03-31 20:54:48]

https://codereview.chromium.org/2778733004/diff/120001/ash/common/wm_window.h
File ash/common/wm_window.h (right):

https://codereview.chromium.org/2778733004/diff/120001/ash/common/wm_window.h...
ash/common/wm_window.h:255: void SetPinType(WindowPinType type);
WmWindow is going to go away. The call sites should set the property directly.

https://codereview.chromium.org/2778733004/diff/120001/chrome/browser/chrome_...
File chrome/browser/chrome_browser_main_extra_parts_exo.cc (right):

https://codereview.chromium.org/2778733004/diff/120001/chrome/browser/chrome_...
chrome/browser/chrome_browser_main_extra_parts_exo.cc:133:
converter->RegisterProperty(
Are you sure you don't need to use the MusPropertyMirror? AFAICT the property is
set on the child aura::Window created by DesktopNativeWidgetAura and not the
top-level window.

https://codereview.chromium.org/2778733004/diff/120001/components/exo/shell_s...
File components/exo/shell_surface_unittest.cc (right):

https://codereview.chromium.org/2778733004/diff/120001/components/exo/shell_s...
components/exo/shell_surface_unittest.cc:56: bool WidgetIsPinned(views::Widget*
widget) {
IsWidgetPinned.

[sky, 2017-03-31 20:55:30]

Also, the property you are adding should go in ash/public/interfaces, not in
window_manager*

[Peng, 2017-04-03 15:10:32]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 15:10:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peng, 2017-04-03 15:11:27]

https://codereview.chromium.org/2778733004/diff/120001/ash/common/wm_window.h
File ash/common/wm_window.h (right):

https://codereview.chromium.org/2778733004/diff/120001/ash/common/wm_window.h...
ash/common/wm_window.h:255: void SetPinType(WindowPinType type);
On 2017/03/31 20:54:47, sky wrote:
> WmWindow is going to go away. The call sites should set the property directly.

Done.

https://codereview.chromium.org/2778733004/diff/120001/chrome/browser/chrome_...
File chrome/browser/chrome_browser_main_extra_parts_exo.cc (right):

https://codereview.chromium.org/2778733004/diff/120001/chrome/browser/chrome_...
chrome/browser/chrome_browser_main_extra_parts_exo.cc:133:
converter->RegisterProperty(
On 2017/03/31 20:54:47, sky wrote:
> Are you sure you don't need to use the MusPropertyMirror? AFAICT the property
is
> set on the child aura::Window created by DesktopNativeWidgetAura and not the
> top-level window.

I added it in ash/public/cpp/mus_property_mirror_ash.cc. Do I need create a
separate MusPropertyMirror? I thought exo and ash will be in the same process
for now.

https://codereview.chromium.org/2778733004/diff/120001/components/exo/shell_s...
File components/exo/shell_surface_unittest.cc (right):

https://codereview.chromium.org/2778733004/diff/120001/components/exo/shell_s...
components/exo/shell_surface_unittest.cc:56: bool WidgetIsPinned(views::Widget*
widget) {
On 2017/03/31 20:54:48, sky wrote:
> IsWidgetPinned.

Done.

[sky, 2017-04-03 16:38:56]

https://codereview.chromium.org/2778733004/diff/140001/ash/common/wm_window.h
File ash/common/wm_window.h (right):

https://codereview.chromium.org/2778733004/diff/140001/ash/common/wm_window.h...
ash/common/wm_window.h:12: #include "ash/public/cpp/window_properties.h"
Move includes to .cc? Also, do you really need both now?

https://codereview.chromium.org/2778733004/diff/140001/ash/public/cpp/window_...
File ash/public/cpp/window_pin_type.h (right):

https://codereview.chromium.org/2778733004/diff/140001/ash/public/cpp/window_...
ash/public/cpp/window_pin_type.h:14: enum class WindowPinType {
Can we only have one enum? Specifically use the enum in ash.mojom directly.

https://codereview.chromium.org/2778733004/diff/140001/chrome/browser/chrome_...
File chrome/browser/chrome_browser_main_extra_parts_exo.cc (right):

https://codereview.chromium.org/2778733004/diff/140001/chrome/browser/chrome_...
chrome/browser/chrome_browser_main_extra_parts_exo.cc:124: void
ChromeBrowserMainExtraPartsExo::ServiceManagerConnectionStarted(
This property is really ash specific. I think you should put this code in
ChromeBrowserMainExtraPartsAsh.

https://codereview.chromium.org/2778733004/diff/140001/components/exo/shell_s...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2778733004/diff/140001/components/exo/shell_s...
components/exo/shell_surface.cc:496: if (pinned) {
Maybe move the determining of type to a function so that this becomes:

widget_->GetNativeWindow()->SetProperty(ash::kWindowPinTypeKey,
GetPinType(pinned, trusted));

[Peng, 2017-04-03 18:03:21]

Patchset #9 (id:160001) has been deleted

[Peng, 2017-04-03 18:03:48]

https://codereview.chromium.org/2778733004/diff/140001/ash/common/wm_window.h
File ash/common/wm_window.h (right):

https://codereview.chromium.org/2778733004/diff/140001/ash/common/wm_window.h...
ash/common/wm_window.h:12: #include "ash/public/cpp/window_properties.h"
On 2017/04/03 16:38:56, sky wrote:
> Move includes to .cc? Also, do you really need both now?

Done.

https://codereview.chromium.org/2778733004/diff/140001/ash/public/cpp/window_...
File ash/public/cpp/window_pin_type.h (right):

https://codereview.chromium.org/2778733004/diff/140001/ash/public/cpp/window_...
ash/public/cpp/window_pin_type.h:14: enum class WindowPinType {
On 2017/04/03 16:38:56, sky wrote:
> Can we only have one enum? Specifically use the enum in ash.mojom directly.

Done.

https://codereview.chromium.org/2778733004/diff/140001/chrome/browser/chrome_...
File chrome/browser/chrome_browser_main_extra_parts_exo.cc (right):

https://codereview.chromium.org/2778733004/diff/140001/chrome/browser/chrome_...
chrome/browser/chrome_browser_main_extra_parts_exo.cc:124: void
ChromeBrowserMainExtraPartsExo::ServiceManagerConnectionStarted(
On 2017/04/03 16:38:56, sky wrote:
> This property is really ash specific. I think you should put this code in
> ChromeBrowserMainExtraPartsAsh.

Done.

https://codereview.chromium.org/2778733004/diff/140001/components/exo/shell_s...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2778733004/diff/140001/components/exo/shell_s...
components/exo/shell_surface.cc:496: if (pinned) {
On 2017/04/03 16:38:56, sky wrote:
> Maybe move the determining of type to a function so that this becomes:
> 
> widget_->GetNativeWindow()->SetProperty(ash::kWindowPinTypeKey,
> GetPinType(pinned, trusted));

Done.

[Peng, 2017-04-03 18:59:04]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 19:00:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 19:20:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 19:20:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peng, 2017-04-03 20:02:16]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 20:03:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peng, 2017-04-03 21:05:39]

penghuang@chromium.org changed reviewers:
+ dcheng@chromium.org, reveman@chromium.org

[Peng, 2017-04-03 21:05:40]

+dcheng@chromium.org  for *.mojom
+reveman@chromium.org for //components/exo/*

Hi Daniel and David, PTAL. Thanks.

[commit-bot: I haz the power, 2017-04-03 21:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 21:21:11]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-04-04 06:58:54]

https://codereview.chromium.org/2778733004/diff/200001/ash/common/wm/window_s...
File ash/common/wm/window_state.cc (right):

https://codereview.chromium.org/2778733004/diff/200001/ash/common/wm/window_s...
ash/common/wm/window_state.cc:367: ash::mojom::WindowPinType pin_type =
ash::mojom::WindowPinType::NONE;
After seeing this and the conversion on line 47, I'm wondering why we bother
with the mojo type at all. Conversions should ideally be typemapped to
centralize the logic... and this isn't doing that.

https://codereview.chromium.org/2778733004/diff/200001/ash/public/cpp/window_...
File ash/public/cpp/window_pin_type.cc (right):

https://codereview.chromium.org/2778733004/diff/200001/ash/public/cpp/window_...
ash/public/cpp/window_pin_type.cc:11: bool IsValidWindowPinType(int64_t value) {
I don't think it should block this CL, but maybe something to consider
long-term... it's very weird that we have to (essentially) duplicate mojo enum
validation. And I don't feel super comfortable that we seem to need to continue
propagating this pattern around in ash.

[reveman, 2017-04-04 07:13:14]

https://codereview.chromium.org/2778733004/diff/200001/components/exo/shell_s...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2778733004/diff/200001/components/exo/shell_s...
components/exo/shell_surface.cc:53: ash::mojom::WindowPinType GetPinType(bool
pinned, bool trusted) {
Please change ShellSurface::SetPinned to take an ash::mojom::WindowPinType
argument instead of two booleans so this function is not needed.

[Peng, 2017-04-04 15:08:06]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[Peng, 2017-04-04 15:08:15]

https://codereview.chromium.org/2778733004/diff/200001/ash/common/wm/window_s...
File ash/common/wm/window_state.cc (right):

https://codereview.chromium.org/2778733004/diff/200001/ash/common/wm/window_s...
ash/common/wm/window_state.cc:367: ash::mojom::WindowPinType pin_type =
ash::mojom::WindowPinType::NONE;
On 2017/04/04 06:58:54, dcheng wrote:
> After seeing this and the conversion on line 47, I'm wondering why we bother
> with the mojo type at all. Conversions should ideally be typemapped to
> centralize the logic... and this isn't doing that.

The function (on line 47) is for converting the mojom window pin type to a
window manager event. I fully understand what is your suggestion.

https://codereview.chromium.org/2778733004/diff/200001/ash/public/cpp/window_...
File ash/public/cpp/window_pin_type.cc (right):

https://codereview.chromium.org/2778733004/diff/200001/ash/public/cpp/window_...
ash/public/cpp/window_pin_type.cc:11: bool IsValidWindowPinType(int64_t value) {
On 2017/04/04 06:58:54, dcheng wrote:
> I don't think it should block this CL, but maybe something to consider
> long-term... it's very weird that we have to (essentially) duplicate mojo enum
> validation. And I don't feel super comfortable that we seem to need to
continue
> propagating this pattern around in ash.

Because either mojom ipc and aura::Window will verify the window pin type, I
think the verification is not necessary here. So remove this function.

Done

https://codereview.chromium.org/2778733004/diff/200001/components/exo/shell_s...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2778733004/diff/200001/components/exo/shell_s...
components/exo/shell_surface.cc:53: ash::mojom::WindowPinType GetPinType(bool
pinned, bool trusted) {
On 2017/04/04 07:13:14, reveman wrote:
> Please change ShellSurface::SetPinned to take an ash::mojom::WindowPinType
> argument instead of two booleans so this function is not needed. 

Done.

[commit-bot: I haz the power, 2017-04-04 15:08:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 16:12:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 16:12:22]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-04 17:04:57]

https://codereview.chromium.org/2778733004/diff/210001/ash/public/cpp/window_...
File ash/public/cpp/window_properties.h (right):

https://codereview.chromium.org/2778733004/diff/210001/ash/public/cpp/window_...
ash/public/cpp/window_properties.h:12: #include
"ash/public/interfaces/window_pin_type.mojom.h"
forward declare enum?

https://codereview.chromium.org/2778733004/diff/210001/ash/public/interfaces/...
File ash/public/interfaces/window_pin_type.mojom (right):

https://codereview.chromium.org/2778733004/diff/210001/ash/public/interfaces/...
ash/public/interfaces/window_pin_type.mojom:21: 
remove extra lines.

https://codereview.chromium.org/2778733004/diff/210001/chrome/browser/ui/view...
File chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc (right):

https://codereview.chromium.org/2778733004/diff/210001/chrome/browser/ui/view...
chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc:60:
aura::PropertyConverter::CreateAcceptAnyValueCallback());
How come you don't need to validate the property? Don't we end sending over the
wire as int64_t?

[Peng, 2017-04-04 17:38:00]

https://codereview.chromium.org/2778733004/diff/210001/ash/public/cpp/window_...
File ash/public/cpp/window_properties.h (right):

https://codereview.chromium.org/2778733004/diff/210001/ash/public/cpp/window_...
ash/public/cpp/window_properties.h:12: #include
"ash/public/interfaces/window_pin_type.mojom.h"
On 2017/04/04 17:04:56, sky wrote:
> forward declare enum?

Done.

https://codereview.chromium.org/2778733004/diff/210001/ash/public/interfaces/...
File ash/public/interfaces/window_pin_type.mojom (right):

https://codereview.chromium.org/2778733004/diff/210001/ash/public/interfaces/...
ash/public/interfaces/window_pin_type.mojom:21: 
On 2017/04/04 17:04:57, sky wrote:
> remove extra lines.

Done.

https://codereview.chromium.org/2778733004/diff/210001/chrome/browser/ui/view...
File chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc (right):

https://codereview.chromium.org/2778733004/diff/210001/chrome/browser/ui/view...
chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc:60:
aura::PropertyConverter::CreateAcceptAnyValueCallback());
On 2017/04/04 17:04:57, sky wrote:
> How come you don't need to validate the property? Don't we end sending over
the
> wire as int64_t?

I thought mojo ipc will verify the ash::mojom::WindowPinType. I understand it
now. All properties are serialized and deserialized as an int64. Changed it
back. 

Done

[Peng, 2017-04-04 17:44:16]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 17:44:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2017-04-04 18:26:16]

lgtm % nits

https://codereview.chromium.org/2778733004/diff/220001/components/exo/shell_s...
File components/exo/shell_surface.h (right):

https://codereview.chromium.org/2778733004/diff/220001/components/exo/shell_s...
components/exo/shell_surface.h:14: #include
"ash/public/interfaces/window_pin_type.mojom.h"
nit: forward declare enum

https://codereview.chromium.org/2778733004/diff/220001/components/exo/wayland...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2778733004/diff/220001/components/exo/wayland...
components/exo/wayland/server.cc:1954: ash::mojom::WindowPinType type =
optional nit: no need for this temporary variable

[commit-bot: I haz the power, 2017-04-04 18:59:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 18:59:31]

Dry run: This issue passed the CQ dry run.

[Peng, 2017-04-04 19:43:09]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[Peng, 2017-04-04 19:43:50]

https://codereview.chromium.org/2778733004/diff/220001/components/exo/shell_s...
File components/exo/shell_surface.h (right):

https://codereview.chromium.org/2778733004/diff/220001/components/exo/shell_s...
components/exo/shell_surface.h:14: #include
"ash/public/interfaces/window_pin_type.mojom.h"
On 2017/04/04 18:26:16, reveman wrote:
> nit: forward declare enum

Done.

https://codereview.chromium.org/2778733004/diff/220001/components/exo/wayland...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2778733004/diff/220001/components/exo/wayland...
components/exo/wayland/server.cc:1954: ash::mojom::WindowPinType type =
On 2017/04/04 18:26:16, reveman wrote:
> optional nit: no need for this temporary variable

Done.

[commit-bot: I haz the power, 2017-04-04 19:44:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 21:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 21:09:15]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-04 21:47:01]

LGTM

[dcheng, 2017-04-04 21:54:52]

lgtm

[Peng, 2017-04-05 00:27:15]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2017-04-05 00:27:15]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2778733004/#ps240001
(title: "Address review issues.")

[commit-bot: I haz the power, 2017-04-05 00:27:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 00:54:49]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1491352035296150,
"parent_rev": "de700d6f9523f7b552ca90f28657cd942c958dbd", "commit_rev":
"e52cb19f44be5e48c4e34189c2c3d7f3439a4160"}

[commit-bot: I haz the power, 2017-04-05 00:55:35]

Description was changed from

==========
Add WindowPinType property on arua::Window

Add WindowPinType property on arua::Window. This property can be used
for requesting pinning a window instead of using ash::wm::PinWindow().

BUG=697586
==========

to

==========
Add WindowPinType property on arua::Window

Add WindowPinType property on arua::Window. This property can be used
for requesting pinning a window instead of using ash::wm::PinWindow().

BUG=697586

Review-Url: https://codereview.chromium.org/2778733004
Cr-Commit-Position: refs/heads/master@{#461923}
Committed:
https://chromium.googlesource.com/chromium/src/+/e52cb19f44be5e48c4e34189c2c3...
==========

[commit-bot: I haz the power, 2017-04-05 00:55:37]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/e52cb19f44be5e48c4e34189c2c3...