Add WindowPinType property on arua::Window

ui/aura/mus/property_converter.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/mus/property_converter.h"
 
 #include "base/memory/ptr_util.h"
 #include "mojo/public/cpp/bindings/type_converter.h"
 #include "services/ui/public/cpp/property_type_converters.h"
 #include "services/ui/public/interfaces/window_manager.mojom.h"
@@ skipping 31 matching lines @@
 
 bool ValidateShowState(int64_t value) {
   return value == int64_t(ui::mojom::ShowState::DEFAULT) ||
          value == int64_t(ui::mojom::ShowState::NORMAL) ||
          value == int64_t(ui::mojom::ShowState::MINIMIZED) ||
          value == int64_t(ui::mojom::ShowState::MAXIMIZED) ||
          value == int64_t(ui::mojom::ShowState::INACTIVE) ||
          value == int64_t(ui::mojom::ShowState::FULLSCREEN);
 }
 
+bool ValidateWindowPinType(int64_t value) {
+  return value == int64_t(ui::mojom::WindowPinType::NONE) ||
+         value == int64_t(ui::mojom::WindowPinType::PINNED) ||
+         value == int64_t(ui::mojom::WindowPinType::TRUSTED_PINNED);
+}
+
 }  // namespace
 
 PropertyConverter::PrimitiveProperty::PrimitiveProperty() {}
 
 PropertyConverter::PrimitiveProperty::PrimitiveProperty(
     const PrimitiveProperty& property) = default;
 
 PropertyConverter::PrimitiveProperty::~PrimitiveProperty() {}
 
 // static
@@ skipping 20 matching lines @@
   RegisterProperty(client::kResizeBehaviorKey,
                    ui::mojom::WindowManager::kResizeBehavior_Property,
                    base::Bind(&ValidateResizeBehaviour));
   RegisterProperty(client::kRestoreBoundsKey,
                    ui::mojom::WindowManager::kRestoreBounds_Property);
   RegisterProperty(client::kShowStateKey,
                    ui::mojom::WindowManager::kShowState_Property,
                    base::Bind(&ValidateShowState));
   RegisterProperty(client::kWindowIconKey,
                    ui::mojom::WindowManager::kWindowIcon_Property);
+  RegisterProperty(client::kWindowPinTypeKey,
+                   ui::mojom::WindowManager::kWindowPinType_Property,

[sky, 2017/03/31 04:40:26]

When you move the classes out of views you'll need to move registration of this
to ash/mus/window_manager.cc and in exo where it creates MusClient. You'll
likely want to create a function that can do the additional registration, say in
ash/public/cpp/property_registration.cc (you'll need to create this). I think
you'll also need to mirror the property in exo. See
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/ash/chrome_brows...
for an example of what I mean.

[Peng, 2017/03/31 18:09:22]

Done.

+                   base::Bind(&ValidateWindowPinType));
   RegisterProperty(client::kTitleKey,
                    ui::mojom::WindowManager::kWindowTitle_Property);
 }
 
 PropertyConverter::~PropertyConverter() {}
 
 bool PropertyConverter::IsTransportNameRegistered(
     const std::string& name) const {
   return transport_names_.count(name) > 0;
 }
@@ skipping 217 matching lines @@
 }
 
 void PropertyConverter::RegisterProperty(
     const WindowProperty<base::string16*>* property,
     const char* transport_name) {
   string16_properties_[property] = transport_name;
   transport_names_.insert(transport_name);
 }
 
 }  // namespace aura