Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2778733003: Pref service: delete old implementation (Closed)

Created:
3 years, 9 months ago by tibell
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, oshima+watch_chromium.org, darin (slow to review), davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pref service: delete old implementation BUG=654988 Review-Url: https://codereview.chromium.org/2778733003 Cr-Commit-Position: refs/heads/master@{#461041} Committed: https://chromium.googlesource.com/chromium/src/+/a3c57fc8fb4259c1696333ba4fa01a9fd623e955

Patch Set 1 #

Patch Set 2 : Remove service_manifest #

Patch Set 3 : Remove pref_client_store_unittest.cc #

Patch Set 4 : Merge #

Patch Set 5 : Fix missed merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1269 lines) Patch
M chrome/app/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chrome_content_browser_manifest_overlay.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences_chromeos_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/prefs/active_profile_pref_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/prefs/forwarder_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/prefs/preferences_connection_manager.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/prefs/preferences_connection_manager.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/prefs/preferences_manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/prefs/preferences_service.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/prefs/preferences_service.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/prefs/preferences_service_unittest.cc View 1 chunk +0 lines, -307 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/pref_service_factory_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M services/preferences/public/cpp/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D services/preferences/public/cpp/pref_client_store.h View 1 chunk +0 lines, -82 lines 0 comments Download
D services/preferences/public/cpp/pref_client_store.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M services/preferences/public/cpp/pref_service_factory.h View 1 chunk +4 lines, -5 lines 0 comments Download
M services/preferences/public/cpp/tests/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D services/preferences/public/cpp/tests/pref_client_store_unittest.cc View 1 2 1 chunk +0 lines, -410 lines 0 comments Download
M services/preferences/public/interfaces/preferences.mojom View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
M services/preferences/unittest_manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 37 (22 generated)
tibell
Remove service_manifest
3 years, 9 months ago (2017-03-28 03:33:55 UTC) #5
tibell
Remove pref_client_store_unittest.cc
3 years, 9 months ago (2017-03-28 03:53:40 UTC) #10
tibell
This is a straightforward deletion of code that is unused after the dependent CL has ...
3 years, 8 months ago (2017-03-29 00:18:11 UTC) #16
Sam McNally
lgtm
3 years, 8 months ago (2017-03-29 06:04:57 UTC) #17
Martin Barbella
mojom lgtm
3 years, 8 months ago (2017-03-29 15:59:59 UTC) #18
Bernhard Bauer
lgtm
3 years, 8 months ago (2017-03-29 16:22:14 UTC) #19
tibell
+sky@chromium.org: friendly ping
3 years, 8 months ago (2017-03-30 23:14:11 UTC) #20
sky
LGTM
3 years, 8 months ago (2017-03-30 23:18:38 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778733003/40001
3 years, 8 months ago (2017-03-30 23:21:56 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/66459) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-03-30 23:26:22 UTC) #25
tibell
Merge
3 years, 8 months ago (2017-03-30 23:59:27 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778733003/60001
3 years, 8 months ago (2017-03-31 00:05:02 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/418951)
3 years, 8 months ago (2017-03-31 00:26:03 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778733003/80001
3 years, 8 months ago (2017-03-31 03:12:40 UTC) #34
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 04:58:37 UTC) #37
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a3c57fc8fb4259c1696333ba4fa0...

Powered by Google App Engine
This is Rietveld 408576698