Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: services/preferences/public/cpp/pref_client_store.h

Issue 2778733003: Pref service: delete old implementation (Closed)
Patch Set: Fix missed merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/preferences/public/cpp/BUILD.gn ('k') | services/preferences/public/cpp/pref_client_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/preferences/public/cpp/pref_client_store.h
diff --git a/services/preferences/public/cpp/pref_client_store.h b/services/preferences/public/cpp/pref_client_store.h
deleted file mode 100644
index c2ac032366c69bffd18cb461a06891f47e0bc272..0000000000000000000000000000000000000000
--- a/services/preferences/public/cpp/pref_client_store.h
+++ /dev/null
@@ -1,82 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef SERVICES_PREFERENCES_PUBLIC_CPP_PREFS_CLIENT_STORE_H_
-#define SERVICES_PREFERENCES_PUBLIC_CPP_PREFS_CLIENT_STORE_H_
-
-#include <set>
-
-#include "base/macros.h"
-#include "components/prefs/value_map_pref_store.h"
-#include "mojo/public/cpp/bindings/binding.h"
-#include "services/preferences/public/interfaces/preferences.mojom.h"
-
-namespace preferences {
-
-class PrefClientStoreTest;
-
-// An implementation of PrefStore which uses prefs::mojom::PreferenceManager as
-// the backing of the preferences.
-//
-// PrefClientStore caches the values locally to provide synchronous access.
-// The cache is empty until the first notification of OnPreferencesChanged is
-// received from the prefs::mojom::PreferenceManager. Upon recieving an initial
-// OnPreferencesChanged initialization will be considered as completed, and any
-// PrefStore::Observer will be notified of OnInitializationCompleted.
-//
-// Currently this does not support RemoveValue.
-class PrefClientStore : public ValueMapPrefStore,
- public prefs::mojom::PreferencesServiceClient {
- public:
- explicit PrefClientStore(
- prefs::mojom::PreferencesServiceFactoryPtr pref_factory_ptr);
-
- // Adds a set of |keys| which PrefClientStore will handle. Begins listening
- // for changes to these from |prefs_service_|.
- void Subscribe(const std::set<std::string>& keys);
-
- // PrefStore:
- bool GetValue(const std::string& key,
- const base::Value** value) const override;
-
- // ValueMapPrefStore:
- void SetValue(const std::string& key,
- std::unique_ptr<base::Value> value,
- uint32_t flags) override;
- void RemoveValue(const std::string& key, uint32_t flags) override;
- bool GetMutableValue(const std::string& key, base::Value** value) override;
- void ReportValueChanged(const std::string& key, uint32_t flags) override;
- void SetValueSilently(const std::string& key,
- std::unique_ptr<base::Value> value,
- uint32_t flags) override;
-
- protected:
- // base::RefCounted<PrefStore>:
- ~PrefClientStore() override;
-
- private:
- friend class PrefClientStoreTest;
-
- // Notifies |prefs_service_| of the change in |key| - |value| pair.
- void SetValueOnPreferenceManager(const std::string& key,
- base::Value const& value);
-
- // prefs::mojom::PreferencesServiceClient:
- void OnPreferencesChanged(
- std::unique_ptr<base::DictionaryValue> preferences) override;
-
- mojo::Binding<prefs::mojom::PreferencesServiceClient> prefs_binding_;
- prefs::mojom::PreferencesServiceFactoryPtr pref_factory_ptr_;
- prefs::mojom::PreferencesServicePtr prefs_service_ptr_;
-
- std::set<std::string> keys_;
-
- // True upon the first OnPreferencesChanged received after Init.
- bool initialized_;
-
- DISALLOW_COPY_AND_ASSIGN(PrefClientStore);
-};
-
-} // namespace preferences
-#endif // SERVICES_PREFERENCES_PUBLIC_CPP_PREFS_CLIENT_STORE_H_
« no previous file with comments | « services/preferences/public/cpp/BUILD.gn ('k') | services/preferences/public/cpp/pref_client_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698