Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2778603002: Remove Open in new window/tab/incognito in ContextMenu for empty URL (Closed)

Created:
3 years, 9 months ago by marcin
Modified:
3 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Open in new window/tab/incognito in ContextMenu for empty URL BUG=680673 Review-Url: https://codereview.chromium.org/2778603002 Cr-Commit-Position: refs/heads/master@{#460031} Committed: https://chromium.googlesource.com/chromium/src/+/ebe1a464baa4fc3e460870ab83f568b2810108ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
marcin
3 years, 9 months ago (2017-03-25 17:14:38 UTC) #3
Ted C
lgtm
3 years, 9 months ago (2017-03-27 21:41:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778603002/1
3 years, 9 months ago (2017-03-28 06:17:22 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 06:53:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ebe1a464baa4fc3e460870ab83f5...

Powered by Google App Engine
This is Rietveld 408576698