Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2099)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 2778603002: Remove Open in new window/tab/incognito in ContextMenu for empty URL (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
index b08de6ed41b4117cd43c10d79721dafdb8edc206..7e847eb79b4cb3811dd3598e2acf12c438c5fe6f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
@@ -389,6 +389,13 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
disabledOptions.add(ContextMenuItem.OPEN_IN_INCOGNITO_TAB);
}
+ if (TextUtils.isEmpty(params.getLinkUrl())
+ || params.getLinkUrl().equals(UrlConstants.ABOUT_BLANK_DISPLAY_URL)) {
+ disabledOptions.add(ContextMenuItem.OPEN_IN_OTHER_WINDOW);
+ disabledOptions.add(ContextMenuItem.OPEN_IN_NEW_TAB);
+ disabledOptions.add(ContextMenuItem.OPEN_IN_INCOGNITO_TAB);
+ }
+
if (MailTo.isMailTo(params.getLinkUrl())) {
disabledOptions.add(ContextMenuItem.COPY_LINK_TEXT);
disabledOptions.add(ContextMenuItem.COPY_LINK_ADDRESS);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698