Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2778523002:
Revert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/ (Closed)
DescriptionRevert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/
According to the discussion in http://crbug.com/702251, we decide to revert this
change on all platforms, and propose a more comprehensive change on Mac OS
during M59.
BUG=702251, 680809
Review-Url: https://codereview.chromium.org/2778523002
Cr-Commit-Position: refs/heads/master@{#459639}
Committed: https://chromium.googlesource.com/chromium/src/+/e84b99c44420c5214aaf0d6b095130f5f6535a4e
Patch Set 1 #
Total comments: 2
Patch Set 2 : Resolve review comments #
Messages
Total messages: 28 (23 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Revert change https://chromium.googlesource.com/chromium/src/+/3c7af99a93f4b4837b2fbee5cb66... According to the discussion in http://crbug.com/702251, we decide to revert this change on all platforms, and propose a more comprehensive change on Mac OS during M59. BUG=702251 ========== to ========== Revert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/ According to the discussion in http://crbug.com/702251, we decide to revert this change on all platforms, and propose a more comprehensive change on Mac OS during M59. BUG=702251 ==========
zijiehe@chromium.org changed reviewers: + dominickn@chromium.org, msw@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Revert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/ According to the discussion in http://crbug.com/702251, we decide to revert this change on all platforms, and propose a more comprehensive change on Mac OS during M59. BUG=702251 ========== to ========== Revert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/ According to the discussion in http://crbug.com/702251, we decide to revert this change on all platforms, and propose a more comprehensive change on Mac OS during M59. BUG=702251, 680809 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with a nit https://codereview.chromium.org/2778523002/diff/40001/chrome/browser/ui/brows... File chrome/browser/ui/browser_command_controller.cc (right): https://codereview.chromium.org/2778523002/diff/40001/chrome/browser/ui/brows... chrome/browser/ui/browser_command_controller.cc:190: if (window()->IsFullscreen() && command_id == IDC_FULLSCREEN) { optional nit: curlies not needed
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
https://codereview.chromium.org/2778523002/diff/40001/chrome/browser/ui/brows... File chrome/browser/ui/browser_command_controller.cc (right): https://codereview.chromium.org/2778523002/diff/40001/chrome/browser/ui/brows... chrome/browser/ui/browser_command_controller.cc:190: if (window()->IsFullscreen() && command_id == IDC_FULLSCREEN) { On 2017/03/25 01:07:26, msw wrote: > optional nit: curlies not needed Different culture :)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by zijiehe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org Link to the patchset: https://codereview.chromium.org/2778523002/#ps60001 (title: "Resolve review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490415447411870,
"parent_rev": "880e49e7bf7d6d11f23d7d4dcd8e2e21b9c142b5", "commit_rev":
"e84b99c44420c5214aaf0d6b095130f5f6535a4e"}
Message was sent while issue was closed.
Description was changed from ========== Revert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/ According to the discussion in http://crbug.com/702251, we decide to revert this change on all platforms, and propose a more comprehensive change on Mac OS during M59. BUG=702251, 680809 ========== to ========== Revert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/ According to the discussion in http://crbug.com/702251, we decide to revert this change on all platforms, and propose a more comprehensive change on Mac OS during M59. BUG=702251, 680809 Review-Url: https://codereview.chromium.org/2778523002 Cr-Commit-Position: refs/heads/master@{#459639} Committed: https://chromium.googlesource.com/chromium/src/+/e84b99c44420c5214aaf0d6b0951... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/e84b99c44420c5214aaf0d6b0951... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
