Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2222)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 2778523002: Revert change http://crrev.com/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/ (Closed)
Patch Set: Resolve review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_command_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc
index e80cf538acf2bb4fee60f26ac052ac085e19f376..8fa33d207c1d87fb53c6cd94973f1dc894f0b413 100644
--- a/chrome/browser/ui/browser_command_controller_unittest.cc
+++ b/chrome/browser/ui/browser_command_controller_unittest.cc
@@ -361,27 +361,25 @@ TEST_F(BrowserCommandControllerFullscreenTest,
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_SHOW_APP_MENU));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
- // In fullscreen, only the exit fullscreen commands are reserved. All other
- // shortcuts should be delivered to the web page. See https://goo.gl/4tJ32G.
- EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
+ EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_CLOSE_TAB,
content::NativeWebKeyboardEvent(blink::WebInputEvent::TypeFirst, 0, 0)));
- EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
+ EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_CLOSE_WINDOW,
content::NativeWebKeyboardEvent(blink::WebInputEvent::TypeFirst, 0, 0)));
- EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
+ EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_NEW_INCOGNITO_WINDOW,
content::NativeWebKeyboardEvent(blink::WebInputEvent::TypeFirst, 0, 0)));
- EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
+ EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_NEW_TAB,
content::NativeWebKeyboardEvent(blink::WebInputEvent::TypeFirst, 0, 0)));
- EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
+ EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_NEW_WINDOW,
content::NativeWebKeyboardEvent(blink::WebInputEvent::TypeFirst, 0, 0)));
- EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
+ EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_SELECT_NEXT_TAB,
content::NativeWebKeyboardEvent(blink::WebInputEvent::TypeFirst, 0, 0)));
- EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
+ EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_SELECT_PREVIOUS_TAB,
content::NativeWebKeyboardEvent(blink::WebInputEvent::TypeFirst, 0, 0)));
EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698