Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2778453003: mac: Fix gn bootstrap after https://codereview.chromium.org/2768933002 (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org, ssid
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Fix gn bootstrap after https://codereview.chromium.org/2768933002 That change added a reference to base::CurrentProcessInfo::CreationTime() in code of base/ that's live in the gn executable. BUG=none Review-Url: https://codereview.chromium.org/2778453003 Cr-Commit-Position: refs/heads/master@{#459510} Committed: https://chromium.googlesource.com/chromium/src/+/64b5d69a2f831f402112dad708a0612f2869aee4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Nico
I hear your code review load is low :-)
3 years, 9 months ago (2017-03-24 18:42:05 UTC) #3
ssid
Thanks! non-owner lgtm
3 years, 9 months ago (2017-03-24 19:01:46 UTC) #5
Scott Hess - ex-Googler
On 2017/03/24 18:42:05, Nico wrote: > I hear your code review load is low :-) ...
3 years, 9 months ago (2017-03-24 19:04:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778453003/1
3 years, 9 months ago (2017-03-24 19:07:47 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 19:15:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/64b5d69a2f831f402112dad708a0...

Powered by Google App Engine
This is Rietveld 408576698