Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2778393002: Add DCHECK to WebViewPlugin helper to assert WebFrameClient params. (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECK to WebViewPlugin helper to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebViewPlugin::WebViewHelper, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 Review-Url: https://codereview.chromium.org/2778393002 Cr-Commit-Position: refs/heads/master@{#460624} Committed: https://chromium.googlesource.com/chromium/src/+/72687bdd262209de03d258b03d14f9eff4554a8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/plugins/renderer/webview_plugin.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
sashab
3 years, 8 months ago (2017-03-29 03:18:45 UTC) #2
joelhockey
lgtm
3 years, 8 months ago (2017-03-29 03:22:07 UTC) #3
sashab
3 years, 8 months ago (2017-03-29 03:23:08 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-03-29 06:31:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778393002/1
3 years, 8 months ago (2017-03-29 06:32:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/350436)
3 years, 8 months ago (2017-03-29 08:15:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778393002/1
3 years, 8 months ago (2017-03-30 01:38:02 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 02:00:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72687bdd262209de03d258b03d14...

Powered by Google App Engine
This is Rietveld 408576698