components/plugins/renderer/webview_plugin.cc - Issue 2778393002: Add DCHECK to WebViewPlugin helper to assert WebFrameClient params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 2778393002: Add DCHECK to WebViewPlugin helper to assert WebFrameClient params. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/plugins/renderer/webview_plugin.cc

diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc

index 075515a0779ff784b51c27f377e22cf38aba4a59..a958c6d7730c0285952fc2460114fdf8207f324f 100644

--- a/components/plugins/renderer/webview_plugin.cc

+++ b/components/plugins/renderer/webview_plugin.cc

@@ -317,6 +317,7 @@ void WebViewPlugin::WebViewHelper::scheduleAnimation() {

void WebViewPlugin::WebViewHelper::didClearWindowObject(

WebLocalFrame* frame) {

+ DCHECK_EQ(frame, web_view_->mainFrame());

if (!plugin_->delegate_)

return;

« no previous file with comments | « no previous file | no next file » | no next file with comments »