Mus-WS / Aura-Mus: Propagate LocalSurfaceId on WindowTreeHost creation

Mus-WS / Aura-Mus: Propagate LocalSurfaceId on WindowTreeHost creation

This CL optionally propagates the current cc::LocalSurfaceId associated 
with a ServerWindow up to the WindowTreeHost embedded within it. When
surface synchronization is turned on, the WindowTreeHost will submit
CompositorFrames to that cc::LocalSurfaceId.

This CL makes no functional changes other than propagation of the
current cc::LocalSurfaceId on:

1. WindowTree::OnEmbed
2. WindowTree::OnTopLevelCreated
3. WindowManager::WmNewDisplayAdded

It is valid for a client to be embedded before a window has been given a
size and so the cc::LocalSurfaceId is passed around optionally.

BUG=672962
Review-Url: https://codereview.chromium.org/2778363002
Cr-Commit-Position: refs/heads/master@{#460271}
Committed: https://chromium.googlesource.com/chromium/src/+/e9d108d62890198ad43c80e0c0be56ac5a38c3c9

[Fady Samuel, 2017-03-28 21:48:43]

Description was changed from

==========
Mus-WS / Aura-Mus: Propagate LocalSurfaceId on WindowTreeHost creation

BUG=
==========

to

==========
Mus-WS / Aura-Mus: Propagate LocalSurfaceId on WindowTreeHost creation

This CL optionally propagates the current cc::LocalSurfaceId associated 
with a ServerWindow up to the WindowTreeHost embedded within it. When
surface synchronization is turned on, the WindowTreeHost will submit
CompositorFrames to that cc::LocalSurfaceId.

This CL makes no functional changes other than propagation of the
current cc::LocalSurfaceId on:

1. WindowTree::OnEmbed
2. WindowTree::OnTopLevelCreated
3. WindowManager::WmNewDisplayAdded

It is valid for a client to be embedded before a window has been given a
size and so the cc::LocalSurfaceId is passed around optionally.

BUG=672962
==========

[Fady Samuel, 2017-03-28 21:49:22]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Fady Samuel, 2017-03-28 21:49:22]

+sky@: per your feedback on https://codereview.chromium.org/2778093003/. I've
taken an alternative approach to LocalSurfaceId plumbing.

+tsepez@ for mojom

[Tom Sepez, 2017-03-28 22:02:38]

lgtm

[Fady Samuel, 2017-03-28 22:31:12]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:31:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-28 22:35:31]

LGTM

https://codereview.chromium.org/2778363002/diff/40001/services/ui/public/inte...
File services/ui/public/interfaces/window_manager.mojom (right):

https://codereview.chromium.org/2778363002/diff/40001/services/ui/public/inte...
services/ui/public/interfaces/window_manager.mojom:161: cc.mojom.LocalSurfaceId?
local_surface_id);
Please document under what conditionsl local_surface_id is not available. This
comment applies to all mojoms you're changing.

[commit-bot: I haz the power, 2017-03-28 22:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:54:30]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Fady Samuel, 2017-03-28 23:30:30]

Thanks Scott! CQ'ing!

https://codereview.chromium.org/2778363002/diff/40001/services/ui/public/inte...
File services/ui/public/interfaces/window_manager.mojom (right):

https://codereview.chromium.org/2778363002/diff/40001/services/ui/public/inte...
services/ui/public/interfaces/window_manager.mojom:161: cc.mojom.LocalSurfaceId?
local_surface_id);
On 2017/03/28 22:35:31, sky wrote:
> Please document under what conditionsl local_surface_id is not available. This
> comment applies to all mojoms you're changing.

Done.

[Fady Samuel, 2017-03-28 23:31:19]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2017-03-28 23:31:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2778363002/#ps60001
(title: "Add comments")

[commit-bot: I haz the power, 2017-03-28 23:32:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:14:15]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2017-03-29 01:15:31]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:16:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:22:43]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Fady Samuel, 2017-03-29 01:23:27]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:24:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:35:06]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[Fady Samuel, 2017-03-29 01:52:03]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:52:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 03:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 03:03:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2017-03-29 03:05:33]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2017-03-29 03:06:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 04:10:22]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490756733346510,
"parent_rev": "215c2ad55d7b2ccd4461033eb697abf0bd5c7f98", "commit_rev":
"e9d108d62890198ad43c80e0c0be56ac5a38c3c9"}

[commit-bot: I haz the power, 2017-03-29 04:11:08]

Description was changed from

==========
Mus-WS / Aura-Mus: Propagate LocalSurfaceId on WindowTreeHost creation

This CL optionally propagates the current cc::LocalSurfaceId associated 
with a ServerWindow up to the WindowTreeHost embedded within it. When
surface synchronization is turned on, the WindowTreeHost will submit
CompositorFrames to that cc::LocalSurfaceId.

This CL makes no functional changes other than propagation of the
current cc::LocalSurfaceId on:

1. WindowTree::OnEmbed
2. WindowTree::OnTopLevelCreated
3. WindowManager::WmNewDisplayAdded

It is valid for a client to be embedded before a window has been given a
size and so the cc::LocalSurfaceId is passed around optionally.

BUG=672962
==========

to

==========
Mus-WS / Aura-Mus: Propagate LocalSurfaceId on WindowTreeHost creation

This CL optionally propagates the current cc::LocalSurfaceId associated 
with a ServerWindow up to the WindowTreeHost embedded within it. When
surface synchronization is turned on, the WindowTreeHost will submit
CompositorFrames to that cc::LocalSurfaceId.

This CL makes no functional changes other than propagation of the
current cc::LocalSurfaceId on:

1. WindowTree::OnEmbed
2. WindowTree::OnTopLevelCreated
3. WindowManager::WmNewDisplayAdded

It is valid for a client to be embedded before a window has been given a
size and so the cc::LocalSurfaceId is passed around optionally.

BUG=672962

Review-Url: https://codereview.chromium.org/2778363002
Cr-Commit-Position: refs/heads/master@{#460271}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9d108d62890198ad43c80e0c0be...
==========

[commit-bot: I haz the power, 2017-03-29 04:11:09]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e9d108d62890198ad43c80e0c0be...