Mus-WS / Aura-Mus: Propagate cc::LocalSurfaceId through WindowData

Mus-WS / Aura-Mus: Propagate cc::LocalSurfaceId through WindowData

When creating a new WindowTreeHost, the cc::LocalSurfaceId is propagated
to use for submitting CompositorFrames. Furthermore, when a client requests
a new top level window, and the window manager provides one, the
cc::LocalSurfaceId is propagated to the client to use for submitting
CompositorFrames.

BUG=672962

[Fady Samuel, 2017-03-28 00:05:08]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 00:05:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-03-28 00:05:31]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Fady Samuel, 2017-03-28 00:05:32]

+sky@ for review.
+tsepez@ for mojom.

[commit-bot: I haz the power, 2017-03-28 00:56:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 00:56:51]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-28 03:44:04]

Can you elaborate under what conditions the surface id is needed? I thought it
was only needed at the embed points, which you hooked up already?

[Fady Samuel, 2017-03-28 03:56:40]

On 2017/03/28 03:44:04, sky wrote:
> Can you elaborate under what conditions the surface id is needed? I thought it
> was only needed at the embed points, which you hooked up already?

I hooked up FrameSinkIds. This hooks up LocalSurfaceIds. The two together make
up a SurfaceId.

[Fady Samuel, 2017-03-28 12:36:14]

On 2017/03/28 03:56:40, Fady Samuel wrote:
> On 2017/03/28 03:44:04, sky wrote:
> > Can you elaborate under what conditions the surface id is needed? I thought
it
> > was only needed at the embed points, which you hooked up already?
> 
> I hooked up FrameSinkIds. This hooks up LocalSurfaceIds. The two together make
> up a SurfaceId.

Let me clarify:

As part of creating a top level window, the bounds are also set before calling
back into the client that requested the top level window in
WindowTreeClient::OnTopLevelCreated:
https://cs.chromium.org/chromium/src/ash/mus/top_level_window_factory.cc?type...

OnEmbed we also need to propagate along the LocalSurfaceId.

Are you concerned about my placing this in WindowData? Perhaps I can pass this
along in OnEmbed and OnTopLevelCreated. In fact, in those cases, I could simply
pass in a full SurfaceId instead of a FrameSinkId and LocalSurfaceId separately
since I know both should be valid. WDYT?

[Fady Samuel, 2017-03-28 12:37:28]

On 2017/03/28 12:36:14, Fady Samuel wrote:
> On 2017/03/28 03:56:40, Fady Samuel wrote:
> > On 2017/03/28 03:44:04, sky wrote:
> > > Can you elaborate under what conditions the surface id is needed? I
thought
> it
> > > was only needed at the embed points, which you hooked up already?
> > 
> > I hooked up FrameSinkIds. This hooks up LocalSurfaceIds. The two together
make
> > up a SurfaceId.
> 
> Let me clarify:
> 
> As part of creating a top level window, the bounds are also set before calling
> back into the client that requested the top level window in
> WindowTreeClient::OnTopLevelCreated:
>
https://cs.chromium.org/chromium/src/ash/mus/top_level_window_factory.cc?type...
> 
> OnEmbed we also need to propagate along the LocalSurfaceId.
> 
> Are you concerned about my placing this in WindowData? Perhaps I can pass this
> along in OnEmbed and OnTopLevelCreated. In fact, in those cases, I could
simply
> pass in a full SurfaceId instead of a FrameSinkId and LocalSurfaceId
separately
> since I know both should be valid. WDYT?

Actually, I take that back...I'm not entirely sure. Are we confident that by the
time we get to OnTopLevelCreated and OnEmbed, the window will have a bounds set?

[Tom Sepez, 2017-03-28 16:40:54]

lgtm

[Fady Samuel, 2017-03-28 21:30:06]

We've decided to abandon this approach. I'm closing this issue and uploading a
new one.

[Fady Samuel, 2017-03-28 21:30:13]

Description was changed from

==========
Mus-WS / Aura-Mus: Propagate cc::LocalSurfaceId through WindowData

When creating a new WindowTreeHost, the cc::LocalSurfaceId is propagated
to use for submitting CompositorFrames. Furthermore, when a client requests
a new top level window, and the window manager provides one, the
cc::LocalSurfaceId is propagated to the client to use for submitting
CompositorFrames.

BUG=672962
==========

to

==========
Mus-WS / Aura-Mus: Propagate cc::LocalSurfaceId through WindowData

When creating a new WindowTreeHost, the cc::LocalSurfaceId is propagated
to use for submitting CompositorFrames. Furthermore, when a client requests
a new top level window, and the window manager provides one, the
cc::LocalSurfaceId is propagated to the client to use for submitting
CompositorFrames.

BUG=672962
==========