Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/418212)
3 years, 8 months ago
(2017-03-28 19:21:51 UTC)
#6
3 years, 8 months ago
(2017-03-29 21:57:00 UTC)
#7
lgtm, but why?
dgozman
Description was changed from ========== [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject It exposes DOMModel ...
3 years, 8 months ago
(2017-03-29 22:41:43 UTC)
#8
Description was changed from
==========
[DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject
It exposes DOMModel already, there is no need for the target.
BUG=none
==========
to
==========
[DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject
It exposes DOMModel already, there is no need for the target.
There is also no need to extend from Common.Object, have an extra field for
nothing and provide event listening capabilities.
BUG=none
==========
dgozman
The CQ bit was checked by dgozman@chromium.org
3 years, 8 months ago
(2017-03-29 22:41:49 UTC)
#9
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1490827309101400, "parent_rev": "fb1ec92eac2f8a6db6d357249563ffa3fca43058", "commit_rev": "f367e006d3be29eadb50d4d161d63dcc24df4620"}
3 years, 8 months ago
(2017-03-30 00:41:48 UTC)
#11
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490827309101400, "parent_rev":
"fb1ec92eac2f8a6db6d357249563ffa3fca43058", "commit_rev":
"f367e006d3be29eadb50d4d161d63dcc24df4620"}
commit-bot: I haz the power
Description was changed from ========== [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject It exposes DOMModel ...
3 years, 8 months ago
(2017-03-30 00:42:48 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
[DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject
It exposes DOMModel already, there is no need for the target.
There is also no need to extend from Common.Object, have an extra field for
nothing and provide event listening capabilities.
BUG=none
==========
to
==========
[DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject
It exposes DOMModel already, there is no need for the target.
There is also no need to extend from Common.Object, have an extra field for
nothing and provide event listening capabilities.
BUG=none
Review-Url: https://codereview.chromium.org/2778283002
Cr-Commit-Position: refs/heads/master@{#460601}
Committed:
https://chromium.googlesource.com/chromium/src/+/f367e006d3be29eadb50d4d161d6...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f367e006d3be29eadb50d4d161d63dcc24df4620
3 years, 8 months ago
(2017-03-30 00:42:50 UTC)
#13
Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject
(Closed)
Created 3 years, 8 months ago by dgozman
Modified 3 years, 8 months ago
Reviewers: pfeldman
Base URL:
Comments: 0