Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2778283002: [DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, shans, dougt+watch_chromium.org, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, je_julie, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, blink-reviews-style_chromium.org, yuzo+watch_chromium.org, dmazzoni, lushnikov+blink_chromium.org, darktears, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not inherit SDK.DOMNode from SDK.SDKObject It exposes DOMModel already, there is no need for the target. There is also no need to extend from Common.Object, have an extra field for nothing and provide event listening capabilities. BUG=none Review-Url: https://codereview.chromium.org/2778283002 Cr-Commit-Position: refs/heads/master@{#460601} Committed: https://chromium.googlesource.com/chromium/src/+/f367e006d3be29eadb50d4d161d63dcc24df4620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -49 lines) Patch
M third_party/WebKit/Source/devtools/front_end/accessibility/ARIAAttributesView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AXTreePane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 4 chunks +10 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
dgozman
What do you think about this?
3 years, 8 months ago (2017-03-28 17:55:38 UTC) #2
pfeldman
lgtm, but why?
3 years, 8 months ago (2017-03-29 21:57:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778283002/1
3 years, 8 months ago (2017-03-29 22:42:35 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 00:42:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f367e006d3be29eadb50d4d161d6...

Powered by Google App Engine
This is Rietveld 408576698