Move GetBaseAppName into install_static.

Move GetBaseAppName into install_static.

In so doing, this CL also contains:

- Change BrowserDistribution::GetShortcutName to use the localized name
  for Chromium rather than a hardcoded string.
- Delete GoogleChromeDistribution::GetShortcutName since the override is
  no longer needed.
- Consistently apply DCHECK_EQ to all public ShellUtil functions that
  take a BrowserDistribution*, and remove such checks from internal
  functions.
- Remove the BrowserDistribution parameter from:
  - ShellUtil::GetCurrentInstallationSuffix
  - ShellUtil::QuickIsChromeRegisteredInHKLM
- Generally reduce the use of BrowserDistribution within ShellUtil where
  sensible.
- Make GetApplicationName an implementation detail of ShellUtil.

This is another step in bringing brand-specific constants together into
one place, eventually leading to the demise of BrowserDistribution.

BUG=373987
Review-Url: https://codereview.chromium.org/2778223004
Cr-Commit-Position: refs/heads/master@{#460813}
Committed: https://chromium.googlesource.com/chromium/src/+/2457cfdf1f7535bff79949664d01d5e9b0e6e985

[grt (UTC plus 2), 2017-03-29 14:18:22]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 14:18:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 14:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 14:44:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[grt (UTC plus 2), 2017-03-29 19:24:18]

Description was changed from

==========
Move GetBaseAppName into install_static.

In so doing, this CL also contains:

- Change BrowserDistribution::GetShortcutName to use the localized name
  for Chromium rather than a hardcoded string.
- Delete GoogleChromeDistribution::GetShortcutName since the override is
  no longer needed.

This is another step in bringing brand-specific constants together into
one place, eventually leading to the demise of BrowserDistribution.

BUG=373987
==========

to

==========
Move GetBaseAppName into install_static.

In so doing, this CL also contains:

- Change BrowserDistribution::GetShortcutName to use the localized name
  for Chromium rather than a hardcoded string.
- Delete GoogleChromeDistribution::GetShortcutName since the override is
  no longer needed.
- Consistently apply DCHECK_EQ to all public ShellUtil functions that
  take a BrowserDistribution*, and remove such checks from internal
  functions.
- Remove the BrowserDistribution parameter from:
  - ShellUtil::GetCurrentInstallationSuffix
  - ShellUtil::QuickIsChromeRegisteredInHKLM
- Generally reduce the use of BrowserDistribution within ShellUtil where
  sensible.
- Make GetApplicationName an implementation detail of ShellUtil.

This is another step in bringing brand-specific constants together into
one place, eventually leading to the demise of BrowserDistribution.

BUG=373987
==========

[grt (UTC plus 2), 2017-03-29 19:24:34]

Patchset #2 (id:20001) has been deleted

[grt (UTC plus 2), 2017-03-29 19:24:52]

Patchset #2 (id:40001) has been deleted

[grt (UTC plus 2), 2017-03-29 19:25:00]

Patchset #1 (id:1) has been deleted

[grt (UTC plus 2), 2017-03-29 19:31:22]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[grt (UTC plus 2), 2017-03-29 19:31:42]

Patchset #1 (id:60001) has been deleted

[grt (UTC plus 2), 2017-03-29 19:32:51]

grt@chromium.org changed reviewers:
+ pmonette@chromium.org

[grt (UTC plus 2), 2017-03-29 19:32:51]

PTAL

[commit-bot: I haz the power, 2017-03-29 19:33:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 20:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 20:22:42]

Dry run: This issue passed the CQ dry run.

[Patrick Monette, 2017-03-30 00:01:41]

lgtm

[grt (UTC plus 2), 2017-03-30 07:23:33]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-03-30 07:23:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
pmonette@chromium.org
Link to the patchset: https://codereview.chromium.org/2778223004/#ps100001
(title: "sync to position 460686")

[commit-bot: I haz the power, 2017-03-30 07:23:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 07:30:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 07:30:52]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2017-03-30 07:59:51]

grt@chromium.org changed reviewers:
+ pkasting@chromium.org

[grt (UTC plus 2), 2017-03-30 07:59:51]

+pkasting for chrome/browser/ui/views OWNERS stamp. Feel free to check the CQ
box if it lgty, Thanks.

[Peter Kasting, 2017-03-30 17:30:02]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2017-03-30 17:30:02]

lgtm

[commit-bot: I haz the power, 2017-03-30 17:30:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 17:36:17]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490895002197240,
"parent_rev": "528dedac25dfabbba42563f5a3039c43864f604b", "commit_rev":
"2457cfdf1f7535bff79949664d01d5e9b0e6e985"}

[commit-bot: I haz the power, 2017-03-30 17:37:07]

Description was changed from

==========
Move GetBaseAppName into install_static.

In so doing, this CL also contains:

- Change BrowserDistribution::GetShortcutName to use the localized name
  for Chromium rather than a hardcoded string.
- Delete GoogleChromeDistribution::GetShortcutName since the override is
  no longer needed.
- Consistently apply DCHECK_EQ to all public ShellUtil functions that
  take a BrowserDistribution*, and remove such checks from internal
  functions.
- Remove the BrowserDistribution parameter from:
  - ShellUtil::GetCurrentInstallationSuffix
  - ShellUtil::QuickIsChromeRegisteredInHKLM
- Generally reduce the use of BrowserDistribution within ShellUtil where
  sensible.
- Make GetApplicationName an implementation detail of ShellUtil.

This is another step in bringing brand-specific constants together into
one place, eventually leading to the demise of BrowserDistribution.

BUG=373987
==========

to

==========
Move GetBaseAppName into install_static.

In so doing, this CL also contains:

- Change BrowserDistribution::GetShortcutName to use the localized name
  for Chromium rather than a hardcoded string.
- Delete GoogleChromeDistribution::GetShortcutName since the override is
  no longer needed.
- Consistently apply DCHECK_EQ to all public ShellUtil functions that
  take a BrowserDistribution*, and remove such checks from internal
  functions.
- Remove the BrowserDistribution parameter from:
  - ShellUtil::GetCurrentInstallationSuffix
  - ShellUtil::QuickIsChromeRegisteredInHKLM
- Generally reduce the use of BrowserDistribution within ShellUtil where
  sensible.
- Make GetApplicationName an implementation detail of ShellUtil.

This is another step in bringing brand-specific constants together into
one place, eventually leading to the demise of BrowserDistribution.

BUG=373987

Review-Url: https://codereview.chromium.org/2778223004
Cr-Commit-Position: refs/heads/master@{#460813}
Committed:
https://chromium.googlesource.com/chromium/src/+/2457cfdf1f7535bff79949664d01...
==========

[commit-bot: I haz the power, 2017-03-30 17:37:09]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2457cfdf1f7535bff79949664d01...