Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10418)

Unified Diff: chrome/install_static/install_modes_unittest.cc

Issue 2778223004: Move GetBaseAppName into install_static. (Closed)
Patch Set: sync to position 460686 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/install_static/install_constants.h ('k') | chrome/install_static/install_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/install_static/install_modes_unittest.cc
diff --git a/chrome/install_static/install_modes_unittest.cc b/chrome/install_static/install_modes_unittest.cc
index 3e0f01bf84c5966bdf155bdb9a05bc7e56cb0785..7b8acf84ed3daab94c542629d0a1c9301480cf97 100644
--- a/chrome/install_static/install_modes_unittest.cc
+++ b/chrome/install_static/install_modes_unittest.cc
@@ -70,6 +70,12 @@ TEST(InstallModes, VerifyModes) {
else
ASSERT_THAT(mode.app_guid, StrEq(L""));
+ // Every mode must have a base app name.
+ ASSERT_THAT(mode.base_app_name, StrNe(L""));
+
+ // Every mode must have a base app id.
+ ASSERT_THAT(mode.base_app_id, StrNe(L""));
+
// The ProgID prefix must not be empty, must be no greater than 11
// characters long, must contain no punctuation, and may not start with a
// digit (https://msdn.microsoft.com/library/windows/desktop/dd542719.aspx).
« no previous file with comments | « chrome/install_static/install_constants.h ('k') | chrome/install_static/install_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698