Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 2778173002: Revert of "Speculatively launch Service Workers on mouse/touch events." (Closed)

Created:
3 years, 8 months ago by horo
Modified:
3 years, 8 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, srahim+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Speculatively launch Service Workers on mouse/touch events." This CL reverts the commits below: - Speculatively launch Service Workers on mouse/touch events. 1/5: https://codereview.chromium.org/2043863003/ cca7ec0e84c6ea291d90a79bfdcbcd5f0a55d612 2/5: https://codereview.chromium.org/2043083002/ 133f8c0b69c28928dfbd0d73ea85740da9712791 3/5: https://codereview.chromium.org/2052613003/ 56f30b7653eff769a4d39d92f8131f5e9f72f0c6 4/5: https://codereview.chromium.org/2045153003/ b9d6af8dfc9c1bcaabe9d67dd6c30c30b3873cbb 5/5: https://codereview.chromium.org/2053573002/ eb269387e90b272408235bef800ad6eb113c4f40 - Don't speculatively start ServiceWorker if it doesn't have FetchEvent handler https://codereview.chromium.org/2393503002 c2ace594258d2912d8732b263aabb13594fed912 BUG=616502 Review-Url: https://codereview.chromium.org/2778173002 Cr-Commit-Position: refs/heads/master@{#460326} Committed: https://chromium.googlesource.com/chromium/src/+/062ef535e5f84efafa48a36a72c43550d964a0a6

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -729 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chrome_service_worker_browsertest.cc View 3 chunks +0 lines, -108 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 4 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 5 chunks +3 lines, -24 lines 0 comments Download
M components/network_hints/common/network_hints_messages.h View 3 chunks +0 lines, -9 lines 0 comments Download
M components/network_hints/renderer/prescient_networking_dispatcher.h View 2 chunks +0 lines, -6 lines 0 comments Download
M components/network_hints/renderer/prescient_networking_dispatcher.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 3 chunks +0 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 4 chunks +0 lines, -103 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.h View 3 chunks +4 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 6 chunks +1 line, -61 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 3 chunks +1 line, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 chunk +0 lines, -153 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/service_worker_context.h View 2 chunks +0 lines, -16 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.h View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 4 chunks +0 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkHints.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/network/NetworkHints.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/public/platform/WebNavigationHintType.h View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/public/platform/WebPrescientNetworking.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 3 chunks +21 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 26 (17 generated)
horo
falken@ Could you please review this?
3 years, 8 months ago (2017-03-29 01:41:37 UTC) #7
falken
lgtm, thanks for the experiment and the removal.
3 years, 8 months ago (2017-03-29 02:17:16 UTC) #8
horo
jochen@ Could you please review this?
3 years, 8 months ago (2017-03-29 02:23:12 UTC) #10
horo
dcheng@ Please review components/network_hints/common/network_hints_messages.h.
3 years, 8 months ago (2017-03-29 02:23:53 UTC) #12
kinuko
lgtm
3 years, 8 months ago (2017-03-29 02:26:05 UTC) #13
dcheng
lgtm
3 years, 8 months ago (2017-03-29 04:00:33 UTC) #16
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-03-29 06:33:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778173002/20001
3 years, 8 months ago (2017-03-29 08:10:29 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 08:17:03 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/062ef535e5f84efafa48a36a72c4...

Powered by Google App Engine
This is Rietveld 408576698