Speculatively launch Service Workers on mouse/touch events. [3/5]

Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/

When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502
Committed: https://crrev.com/2cba6671596841c77457423e70e9d12070425dd1
Committed: https://crrev.com/56f30b7653eff769a4d39d92f8131f5e9f72f0c6
Cr-Original-Commit-Position: refs/heads/master@{#407695}
Cr-Commit-Position: refs/heads/master@{#407775}

[horo, 2016-06-09 05:02:41]

Description was changed from

==========
003
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

[horo, 2016-06-09 05:04:48]

Patchset #1 (id:1) has been deleted

[horo, 2016-06-09 05:05:02]

Patchset #1 (id:20001) has been deleted

[horo, 2016-06-15 10:39:23]

Patchset #3 (id:80001) has been deleted

[horo, 2016-06-23 02:04:56]

Patchset #4 (id:120001) has been deleted

[horo, 2016-06-23 02:05:01]

Patchset #3 (id:100001) has been deleted

[horo, 2016-06-27 09:10:24]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

[horo, 2016-06-27 09:15:26]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ResourceHintsHandlerImpl receives NavigationHint mojo IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

[horo, 2016-07-14 04:45:23]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 04:45:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-07-14 10:24:27]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ResourceHintsHandlerImpl receives NavigationHint mojo IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

[horo, 2016-07-14 10:26:19]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

[horo, 2016-07-14 10:27:36]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ResourceHintsHandlerImpl
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ResourceHintsHandlerImpl
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

[horo, 2016-07-19 05:04:25]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 05:04:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-07-25 04:10:18]

Patchset #7 (id:220001) has been deleted

[horo, 2016-07-25 04:10:22]

Patchset #6 (id:200001) has been deleted

[horo, 2016-07-25 04:10:29]

Patchset #5 (id:180001) has been deleted

[horo, 2016-07-25 04:10:30]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[horo, 2016-07-25 04:10:32]

Patchset #4 (id:160001) has been deleted

[horo, 2016-07-25 04:10:35]

Patchset #3 (id:140001) has been deleted

[horo, 2016-07-25 04:10:39]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-07-25 04:10:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-07-25 04:10:44]

Patchset #1 (id:40001) has been deleted

[horo, 2016-07-25 04:11:22]

Patchset #2 (id:180001) has been deleted

[horo, 2016-07-25 04:11:26]

Patchset #1 (id:60001) has been deleted

[horo, 2016-07-25 04:12:43]

Patchset #3 (id:280001) has been deleted

[commit-bot: I haz the power, 2016-07-25 04:13:01]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[horo, 2016-07-25 04:13:30]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 04:13:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2016-07-25 04:16:54]

horo@chromium.org changed reviewers:
+ nhiroki@chromium.org

[horo, 2016-07-25 04:16:55]

nhiroki@
Could you please review this CL?

[commit-bot: I haz the power, 2016-07-25 05:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 05:50:54]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2016-07-25 06:15:14]

https://codereview.chromium.org/2052613003/diff/300001/chrome/browser/rendere...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):

https://codereview.chromium.org/2052613003/diff/300001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_render_message_filter.cc:13: #include
"base/feature_list.h"
Are this and other header inclusions added by this change necessary?

https://codereview.chromium.org/2052613003/diff/300001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_render_message_filter.cc:34: #include
"content/public/browser/render_process_host.h"
#include "content/public/browser/service_worker_context.h"

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
File content/browser/service_worker/service_worker_context_wrapper.cc (right):

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.cc:97: default:
I'd prefer to list all enum types on switch-statement if the number of them are
low so that we can detect a missing on compile time.

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.cc:336:
context_core_->storage()->FindRegistrationForDocument(
ServiceWorkerContextWrapper::FindReadyRegistrationForDocument() could be better
because it enables to speculatively start a stored waiting version and we could
expect that an initial launch after registration update becomes faster.

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.cc:356:
context_core_->process_manager()->AddProcessReferenceToPattern(
Let me check my understanding... we add a process reference here because we want
to ensure that a service worker is allocated on the same renderer process as a
document. Is this correct? If so, can you add a comment about the reason why we
do this here?

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
File content/browser/service_worker/service_worker_context_wrapper.h (right):

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.h:253: const
scoped_refptr<ServiceWorkerRegistration>& registration);
Passing a smart pointer by const-reference is no longer encouraged:
http://www.chromium.org/developers/smart-pointer-guidelines#TOC-What-about-pa...

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_metrics.cc:206: return "Navigation
Hint Link Tap Unconfiemed";
s/Unconfiemed/Unconfirmed/

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
File content/public/browser/service_worker_context.h (right):

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
content/public/browser/service_worker_context.h:114: // thread. The |callback|
will always be called on the UI thred.
s/UI thred/UI thread/

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
content/public/browser/service_worker_context.h:117: //  * The specified render
process is suitable for loading |document_url|.
is suitable -> is not suitable ?

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
content/public/browser/service_worker_context.h:118: //    This check is done by
RenderProcessHostImpl::IsSuitableHost().
RenderProcessHostImpl::IsSuitableHost() is an implementation detail and it might
not be necessary to mention in a public interface.

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
content/public/browser/service_worker_context.h:119: //  * Something unexpected
goes wrong, like a renderer crash.
This would be obvious and not necessary.

[horo, 2016-07-25 08:24:27]

Thank you

https://codereview.chromium.org/2052613003/diff/300001/chrome/browser/rendere...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):

https://codereview.chromium.org/2052613003/diff/300001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_render_message_filter.cc:13: #include
"base/feature_list.h"
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> Are this and other header inclusions added by this change necessary?

Done.

https://codereview.chromium.org/2052613003/diff/300001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_render_message_filter.cc:34: #include
"content/public/browser/render_process_host.h"
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> #include "content/public/browser/service_worker_context.h"

Done.

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
File content/browser/service_worker/service_worker_context_wrapper.cc (right):

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.cc:97: default:
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> I'd prefer to list all enum types on switch-statement if the number of them
are
> low so that we can detect a missing on compile time.

Done.

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.cc:336:
context_core_->storage()->FindRegistrationForDocument(
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> ServiceWorkerContextWrapper::FindReadyRegistrationForDocument() could be
better
> because it enables to speculatively start a stored waiting version and we
could
> expect that an initial launch after registration update becomes faster.

Done.

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.cc:356:
context_core_->process_manager()->AddProcessReferenceToPattern(
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> Let me check my understanding... we add a process reference here because we
want
> to ensure that a service worker is allocated on the same renderer process as a
> document. Is this correct? If so, can you add a comment about the reason why
we
> do this here?

Done.

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
File content/browser/service_worker/service_worker_context_wrapper.h (right):

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_context_wrapper.h:253: const
scoped_refptr<ServiceWorkerRegistration>& registration);
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> Passing a smart pointer by const-reference is no longer encouraged:
>
http://www.chromium.org/developers/smart-pointer-guidelines#TOC-What-about-pa...

Done by https://codereview.chromium.org/2181553003.

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/2052613003/diff/300001/content/browser/servic...
content/browser/service_worker/service_worker_metrics.cc:206: return "Navigation
Hint Link Tap Unconfiemed";
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> s/Unconfiemed/Unconfirmed/

Done.

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
File content/public/browser/service_worker_context.h (right):

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
content/public/browser/service_worker_context.h:114: // thread. The |callback|
will always be called on the UI thred.
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> s/UI thred/UI thread/

Done.

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
content/public/browser/service_worker_context.h:117: //  * The specified render
process is suitable for loading |document_url|.
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> is suitable -> is not suitable ?

Done.

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
content/public/browser/service_worker_context.h:118: //    This check is done by
RenderProcessHostImpl::IsSuitableHost().
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> RenderProcessHostImpl::IsSuitableHost() is an implementation detail and it
might
> not be necessary to mention in a public interface.

Done.

https://codereview.chromium.org/2052613003/diff/300001/content/public/browser...
content/public/browser/service_worker_context.h:119: //  * Something unexpected
goes wrong, like a renderer crash.
On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> This would be obvious and not necessary.

Done.

[nhiroki, 2016-07-25 09:26:45]

lgtm with a minor comment

https://codereview.chromium.org/2052613003/diff/300001/chrome/browser/rendere...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):

https://codereview.chromium.org/2052613003/diff/300001/chrome/browser/rendere...
chrome/browser/renderer_host/chrome_render_message_filter.cc:13: #include
"base/feature_list.h"
On 2016/07/25 08:24:26, horo wrote:
> On 2016/07/25 06:15:13, nhiroki (slow) wrote:
> > Are this and other header inclusions added by this change necessary?
> 
> Done.

How about storage_partition.h and content_features.h?

[horo, 2016-07-25 12:17:14]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

BUG=616502
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502
==========

[horo, 2016-07-25 12:20:42]

horo@chromium.org changed reviewers:
+ jochen@chromium.org

[horo, 2016-07-25 12:20:43]

jochen@
Please review chrome/browser/renderer_host/chrome_render_message_filter.* and
content/public/browser/service_worker_context.h.

[jochen (gone - plz use gerrit), 2016-07-25 16:24:06]

lgtm

[horo, 2016-07-25 23:07:25]

The CQ bit was checked by horo@chromium.org

[horo, 2016-07-25 23:07:26]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2052613003/#ps340001
(title: "remove unnecessary includes")

[commit-bot: I haz the power, 2016-07-25 23:08:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 00:24:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 00:24:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[horo, 2016-07-26 01:46:02]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-07-26 01:46:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 03:10:00]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502
==========

[commit-bot: I haz the power, 2016-07-26 03:10:02]

Committed patchset #5 (id:340001)

[commit-bot: I haz the power, 2016-07-26 03:12:11]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/
     
When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/

When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502

Committed: https://crrev.com/2cba6671596841c77457423e70e9d12070425dd1
Cr-Commit-Position: refs/heads/master@{#407695}
==========

[commit-bot: I haz the power, 2016-07-26 03:12:13]

Patchset 5 (id:??) landed as
https://crrev.com/2cba6671596841c77457423e70e9d12070425dd1
Cr-Commit-Position: refs/heads/master@{#407695}

[horo, 2016-07-26 12:08:25]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/

When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502

Committed: https://crrev.com/2cba6671596841c77457423e70e9d12070425dd1
Cr-Commit-Position: refs/heads/master@{#407695}
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/

When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502

Committed: https://crrev.com/2cba6671596841c77457423e70e9d12070425dd1
Cr-Commit-Position: refs/heads/master@{#407695}
==========

[horo, 2016-07-26 12:08:34]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2016-07-26 12:08:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 12:12:23]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/

When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502

Committed: https://crrev.com/2cba6671596841c77457423e70e9d12070425dd1
Cr-Commit-Position: refs/heads/master@{#407695}
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/

When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502

Committed: https://crrev.com/2cba6671596841c77457423e70e9d12070425dd1
Cr-Commit-Position: refs/heads/master@{#407695}
==========

[commit-bot: I haz the power, 2016-07-26 12:12:25]

Committed patchset #5 (id:340001)

[commit-bot: I haz the power, 2016-07-26 12:14:43]

Description was changed from

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/

When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502

Committed: https://crrev.com/2cba6671596841c77457423e70e9d12070425dd1
Cr-Commit-Position: refs/heads/master@{#407695}
==========

to

==========
Speculatively launch Service Workers on mouse/touch events. [3/5]

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/

When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502

Committed: https://crrev.com/2cba6671596841c77457423e70e9d12070425dd1
Committed: https://crrev.com/56f30b7653eff769a4d39d92f8131f5e9f72f0c6
Cr-Original-Commit-Position: refs/heads/master@{#407695}
Cr-Commit-Position: refs/heads/master@{#407775}
==========

[commit-bot: I haz the power, 2016-07-26 12:14:45]

Patchset 5 (id:??) landed as
https://crrev.com/56f30b7653eff769a4d39d92f8131f5e9f72f0c6
Cr-Commit-Position: refs/heads/master@{#407775}