Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2778153002: Add missing header files to GN files (Closed)

Created:
3 years, 9 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, blink-reviews-html_chromium.org, vakh+watch_chromium.org, vmpstr+watch_chromium.org, binji+watch_chromium.org, eae+blinkwatch, teravest+watch_chromium.org, agrieve+watch_chromium.org, kinuko+watch, yusukes+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, tzik, jam, net-reviews_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, darin-cc_chromium.org, wanming.lin, blink-reviews, chromium-apps-reviews_chromium.org, rwlbuis, ihf+watch_chromium.org, mlamouri+watch-content_chromium.org, jchaffraix+rendering, zoltan1, blink-reviews-layout_chromium.org, sof, timvolodine, johnmaguire+watch_google.com, media-router+watch_chromium.org, bradnelson+warch_chromium.org, haraken, piman+watch_chromium.org, szager+layoutwatch_chromium.org, rjkroege, Dirk Pranke, Dai Mikurube (NOT FULLTIME), shalamov, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, wfh+watch_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, mcasas+geolocation_chromium.org, mvanouwerkerk+watch_chromium.org, dominicc+watchlist_chromium.org, tfarina, blink-reviews-frames_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing header files to GN files I ran check_gn_headers.py on linux and android full builds, merged the missing header file list, fed to fix_gn_headers.py, and manually fixed the results. Read more about the manual fixes in the Review-Url. The number of missing header files on linux and android decreased by 154, from 990 to 836. The following spreadsheet is updated. https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0 fix_gn_headers.py is from https://codereview.chromium.org/2781603003 BUG=661774 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2778153002 Cr-Commit-Position: refs/heads/master@{#460942} Committed: https://chromium.googlesource.com/chromium/src/+/589d05ed666fd48defd3cd338e8e23a2bcc21937

Patch Set 1 : run script and format #

Patch Set 2 : manual fix #

Patch Set 3 : manual fix for non-component build #

Patch Set 4 : manual fix for CrOS #

Total comments: 7

Patch Set 5 : address comments #

Patch Set 6 : merge #

Patch Set 7 : fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -1 line) Patch
M base/allocator/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/router/discovery/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/renderer/plugin/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 2 3 4 5 6 chunks +7 lines, -0 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 4 chunks +7 lines, -0 lines 0 comments Download
M extensions/browser/api/metrics_private/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M gpu/khronos_glcts_support/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/c/BUILD.gn View 1 5 chunks +27 lines, -0 lines 0 comments Download
M ppapi/native_client/src/untrusted/irt_stub/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/thunk/BUILD.gn View 1 4 chunks +13 lines, -0 lines 0 comments Download
M services/ui/public/cpp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 9 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BUILD.gn View 7 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/android_crazy_linker/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/freetype/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 1 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/libpng/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/snappy/BUILD.gn View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M tools/gn/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/ipc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/ipc/color/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/ipc/geometry/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/ipc/skia/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/init/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 60 (49 generated)
wychen
PTAL
3 years, 9 months ago (2017-03-28 08:24:47 UTC) #17
Nico
Nice! The last two comments below are real. https://codereview.chromium.org/2778153002/diff/60001/chrome/browser/media/router/discovery/BUILD.gn File chrome/browser/media/router/discovery/BUILD.gn (left): https://codereview.chromium.org/2778153002/diff/60001/chrome/browser/media/router/discovery/BUILD.gn#oldcode20 chrome/browser/media/router/discovery/BUILD.gn:20: "dial/device_description_fetcher.h ...
3 years, 8 months ago (2017-03-28 14:47:50 UTC) #20
wychen
https://codereview.chromium.org/2778153002/diff/60001/third_party/snappy/BUILD.gn File third_party/snappy/BUILD.gn (right): https://codereview.chromium.org/2778153002/diff/60001/third_party/snappy/BUILD.gn#newcode37 third_party/snappy/BUILD.gn:37: "linux/snappy-stubs-public.h", On 2017/03/28 14:47:50, Nico wrote: > Probably doesn't ...
3 years, 8 months ago (2017-03-28 22:12:48 UTC) #35
Nico
lgtm
3 years, 8 months ago (2017-03-29 12:24:26 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778153002/120001
3 years, 8 months ago (2017-03-29 12:24:46 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/397448)
3 years, 8 months ago (2017-03-29 12:32:30 UTC) #46
wychen
brettw@, could you take a look? It's GN-related, and similar to https://codereview.chromium.org/2770693003/ by thakis.
3 years, 8 months ago (2017-03-29 17:09:28 UTC) #48
brettw
rs lgtm
3 years, 8 months ago (2017-03-30 20:42:13 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778153002/120001
3 years, 8 months ago (2017-03-30 21:25:06 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778153002/120001
3 years, 8 months ago (2017-03-30 22:12:45 UTC) #57
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 00:08:17 UTC) #60
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/589d05ed666fd48defd3cd338e8e...

Powered by Google App Engine
This is Rietveld 408576698