Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: third_party/snappy/BUILD.gn

Issue 2778153002: Add missing header files to GN files (Closed)
Patch Set: manual fix for CrOS Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 6
7 config("snappy_config") { 7 config("snappy_config") {
8 include_dirs = [ "src" ] 8 include_dirs = [ "src" ]
9 9
10 # These OS-specific generated headers were made by running the configure 10 # These OS-specific generated headers were made by running the configure
(...skipping 16 matching lines...) Expand all
27 cflags += [ "-Wno-unused-function" ] 27 cflags += [ "-Wno-unused-function" ]
28 } 28 }
29 29
30 if (is_win) { 30 if (is_win) {
31 cflags += [ "/wd4018" ] # Signed/unsigned mismatch in comparison. 31 cflags += [ "/wd4018" ] # Signed/unsigned mismatch in comparison.
32 } 32 }
33 } 33 }
34 34
35 static_library("snappy") { 35 static_library("snappy") {
36 sources = [ 36 sources = [
37 "linux/snappy-stubs-public.h",
Nico 2017/03/28 14:47:50 Probably doesn't use the linux version on all plat
wychen 2017/03/28 22:12:48 Good catch!
37 "src/snappy-internal.h", 38 "src/snappy-internal.h",
38 "src/snappy-sinksource.cc", 39 "src/snappy-sinksource.cc",
39 "src/snappy-sinksource.h", 40 "src/snappy-sinksource.h",
40 "src/snappy-stubs-internal.cc", 41 "src/snappy-stubs-internal.cc",
41 "src/snappy-stubs-internal.h", 42 "src/snappy-stubs-internal.h",
42 "src/snappy.cc", 43 "src/snappy.cc",
43 "src/snappy.h", 44 "src/snappy.h",
44 ] 45 ]
45 46
46 configs -= [ "//build/config/compiler:chromium_code" ] 47 configs -= [ "//build/config/compiler:chromium_code" ]
47 configs += [ 48 configs += [
48 "//build/config/compiler:no_chromium_code", 49 "//build/config/compiler:no_chromium_code",
49 50
50 # Must be after no_chromium_code for warning flags to be ordered correctly. 51 # Must be after no_chromium_code for warning flags to be ordered correctly.
51 ":snappy_warnings", 52 ":snappy_warnings",
52 ] 53 ]
53 public_configs = [ ":snappy_config" ] 54 public_configs = [ ":snappy_config" ]
54 55
55 # Chromium doesn't use automake, but we generated config.h offline for all the 56 # Chromium doesn't use automake, but we generated config.h offline for all the
56 # platforms that we build for. 57 # platforms that we build for.
57 defines = [ "HAVE_CONFIG_H" ] 58 defines = [ "HAVE_CONFIG_H" ]
58 } 59 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698