Chromium Code Reviews
DescriptionRevert of Add operator<< to StyleDifference for debug logging. (patchset #5 id:80001 of https://codereview.chromium.org/2763643003/ )
Reason for revert:
Consistent failure: webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4)
WebKit Android (Nexus4) [50 since first detection]
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29:
The first failure:
-
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/62765
Test output:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F62765%2F%2B%2Frecipes%2Fsteps%2Fwebkit_unit_tests%2F0%2Fstdout
C 169.736s Main [FAIL] StyleDifferenceTest.StreamOutputAllFieldsMutated:
C 169.736s Main [ RUN ] StyleDifferenceTest.StreamOutputAllFieldsMutated
C 169.736s Main ../../third_party/WebKit/Source/core/style/StyleDifferenceTest.cpp:40: Failure
C 169.736s Main Value of: stringStream.str()
C 169.736s Main Actual: "StyleDifference{layoutType=PositionedMovement, paintInvalidationType=PaintInvalidationObject, recomputeOverflow=1, visualRectUpdate=1, propertySpecificDifferences=TransformChanged|ScrollAnchorDisablingPropertyChanged}"
C 169.736s Main Expected: "StyleDifference{layoutType=PositionedMovement, " "paintInvalidationType=PaintInvalidationObject, recomputeOverflow=1, " "visualRectUpdate=1, " "propertySpecificDifferences=TransformChanged|" "ScrollAnchorDisablingPropertyChanged|TransformChanged|" "ScrollAnchorDisablingPropertyChanged}"
C 169.736s Main Which is: "StyleDifference{layoutType=PositionedMovement, paintInvalidationType=PaintInvalidationObject, recomputeOverflow=1, visualRectUpdate=1, propertySpecificDifferences=TransformChanged|ScrollAnchorDisablingPropertyChanged|TransformChanged|ScrollAnchorDisablingPropertyChanged}"
Original issue's description:
> Add operator<< to StyleDifference for debug logging.
>
> Similar to http://crrev.com/2732643004. I wanted this while debugging animation
> related style changes and thought it would be potentially useful for others
> ongoing.
>
> BUG=695125
>
> Review-Url: https://codereview.chromium.org/2763643003
> Cr-Commit-Position: refs/heads/master@{#459595}
> Committed: https://chromium.googlesource.com/chromium/src/+/15eb85b8cb9d52cb79dc37dff7d2cfcd2400e778
TBR=alancutter@chromium.org,wangxianzhu@chromium.org,wkorman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=695125
Review-Url: https://codereview.chromium.org/2777803002
Cr-Commit-Position: refs/heads/master@{#459746}
Committed: https://chromium.googlesource.com/chromium/src/+/eb14d83f2208140bbde345c88f02b7a45736d553
Patch Set 1 #Patch Set 2 : resolve conflict #
Messages
Total messages: 11 (5 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||