Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2777803002: Revert of Add operator<< to StyleDifference for debug logging. (Closed)

Created:
3 years, 9 months ago by hayato
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, suzyh_UTC10 (ex-contributor)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add operator<< to StyleDifference for debug logging. (patchset #5 id:80001 of https://codereview.chromium.org/2763643003/ ) Reason for revert: Consistent failure: webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4) WebKit Android (Nexus4) [50 since first detection] https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29: The first failure: - https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/62765 Test output: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F62765%2F%2B%2Frecipes%2Fsteps%2Fwebkit_unit_tests%2F0%2Fstdout C 169.736s Main [FAIL] StyleDifferenceTest.StreamOutputAllFieldsMutated: C 169.736s Main [ RUN ] StyleDifferenceTest.StreamOutputAllFieldsMutated C 169.736s Main ../../third_party/WebKit/Source/core/style/StyleDifferenceTest.cpp:40: Failure C 169.736s Main Value of: stringStream.str() C 169.736s Main Actual: "StyleDifference{layoutType=PositionedMovement, paintInvalidationType=PaintInvalidationObject, recomputeOverflow=1, visualRectUpdate=1, propertySpecificDifferences=TransformChanged|ScrollAnchorDisablingPropertyChanged}" C 169.736s Main Expected: "StyleDifference{layoutType=PositionedMovement, " "paintInvalidationType=PaintInvalidationObject, recomputeOverflow=1, " "visualRectUpdate=1, " "propertySpecificDifferences=TransformChanged|" "ScrollAnchorDisablingPropertyChanged|TransformChanged|" "ScrollAnchorDisablingPropertyChanged}" C 169.736s Main Which is: "StyleDifference{layoutType=PositionedMovement, paintInvalidationType=PaintInvalidationObject, recomputeOverflow=1, visualRectUpdate=1, propertySpecificDifferences=TransformChanged|ScrollAnchorDisablingPropertyChanged|TransformChanged|ScrollAnchorDisablingPropertyChanged}" Original issue's description: > Add operator<< to StyleDifference for debug logging. > > Similar to http://crrev.com/2732643004. I wanted this while debugging animation > related style changes and thought it would be potentially useful for others > ongoing. > > BUG=695125 > > Review-Url: https://codereview.chromium.org/2763643003 > Cr-Commit-Position: refs/heads/master@{#459595} > Committed: https://chromium.googlesource.com/chromium/src/+/15eb85b8cb9d52cb79dc37dff7d2cfcd2400e778 TBR=alancutter@chromium.org,wangxianzhu@chromium.org,wkorman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=695125 Review-Url: https://codereview.chromium.org/2777803002 Cr-Commit-Position: refs/heads/master@{#459746} Committed: https://chromium.googlesource.com/chromium/src/+/eb14d83f2208140bbde345c88f02b7a45736d553

Patch Set 1 #

Patch Set 2 : resolve conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -167 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleDifference.h View 1 4 chunks +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleDifference.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleDifferenceTest.cpp View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
hayato
Created Revert of Add operator<< to StyleDifference for debug logging.
3 years, 9 months ago (2017-03-27 04:53:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777803002/1
3 years, 9 months ago (2017-03-27 04:54:06 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/63024) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-27 04:56:16 UTC) #5
hayato
resolve conflict
3 years, 9 months ago (2017-03-27 09:02:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777803002/130001
3 years, 9 months ago (2017-03-27 09:03:04 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 10:57:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/eb14d83f2208140bbde345c88f02...

Powered by Google App Engine
This is Rietveld 408576698