Add operator<< to StyleDifference for debug logging.

Add operator<< to StyleDifference for debug logging.

Similar to http://crrev.com/2732643004. I wanted this while debugging animation
related style changes and thought it would be potentially useful for others
ongoing.

BUG=695125
Review-Url: https://codereview.chromium.org/2763643003
Cr-Commit-Position: refs/heads/master@{#459595}
Committed: https://chromium.googlesource.com/chromium/src/+/15eb85b8cb9d52cb79dc37dff7d2cfcd2400e778

[wkorman, 2017-03-20 21:09:06]

wkorman@chromium.org changed reviewers:
+ suzyh@chromium.org, wangxianzhu@chromium.org

[wkorman, 2017-03-20 21:09:06]

I explored using a mix of FOR_EACH pattern and what we do for DisplayItem::Type
(see DisplayItem.h with xxFirst, xxLast, etc.) and PaintPhase (where I did
follow the use of xxxMax value) to dynamically generate the strings rather than
having to duplicate them, but it felt more verbose than just typing them out as
there are three different enums.

See change ref'd in description for something like what that would look like,
but make it ~3x with add'l complexity for or-ed bits for property flags.

I'm still open to doing it that way instead if folks feel it'd be better. Am on
the fence.

meade@ is OOO til Mar 27 so +suzyh to review or help route.

[Xianzhu, 2017-03-20 21:14:12]

lgtm

https://codereview.chromium.org/2763643003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/StyleDifference.h (right):

https://codereview.chromium.org/2763643003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/StyleDifference.h:162: CORE_EXPORT
std::ostream& operator<<(std::ostream&, const StyleDifference);
Nit: either 'const StyleDifference&' or 'StyleDifference'.

[wkorman, 2017-03-20 23:04:29]

https://codereview.chromium.org/2763643003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/StyleDifference.h (right):

https://codereview.chromium.org/2763643003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/StyleDifference.h:162: CORE_EXPORT
std::ostream& operator<<(std::ostream&, const StyleDifference);
On 2017/03/20 21:14:11, Xianzhu wrote:
> Nit: either 'const StyleDifference&' or 'StyleDifference'.

Done.

[suzyh_UTC10 (ex-contributor), 2017-03-20 23:33:07]

suzyh@chromium.org changed reviewers:
+ shend@chromium.org
- suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-03-20 23:33:21]

suzyh@chromium.org changed reviewers:
+ suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-03-20 23:33:21]

Redirecting as requested:
-suzyh +shend

[suzyh_UTC10 (ex-contributor), 2017-03-20 23:34:43]

suzyh@chromium.org changed reviewers:
- suzyh@chromium.org

[shend, 2017-03-20 23:47:29]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-03-20 23:47:29]

Rerouting to alancutter for OWNERS.

[shend, 2017-03-20 23:47:46]

shend@chromium.org changed reviewers:
- shend@chromium.org

[alancutter (OOO until 2018), 2017-03-20 23:57:31]

alancutter@chromium.org changed reviewers:
+ shend@chromium.org

[alancutter (OOO until 2018), 2017-03-20 23:57:32]

lgtm

https://codereview.chromium.org/2763643003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/StyleDifference.h (right):

https://codereview.chromium.org/2763643003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/StyleDifference.h:8: #include <iosfwd>
TIL iosfwd, neat.

[shend, 2017-03-21 02:54:59]

shend@chromium.org changed reviewers:
- shend@chromium.org

[wkorman, 2017-03-22 23:06:14]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-03-22 23:06:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2763643003/#ps40001
(title: "Sync to head.")

[commit-bot: I haz the power, 2017-03-22 23:06:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:07:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:07:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[wkorman, 2017-03-24 19:28:18]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-03-24 19:28:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2763643003/#ps60001
(title: "Sync to head.")

[commit-bot: I haz the power, 2017-03-24 19:28:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 20:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:36:03]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[wkorman, 2017-03-24 21:43:37]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-03-24 21:43:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org, alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2763643003/#ps80001
(title: "Add CORE_EXPORT.")

[commit-bot: I haz the power, 2017-03-24 21:44:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 23:25:13]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490391817604220,
"parent_rev": "3a448977b4cfb0c9ac4bc96148bd675b44623fa7", "commit_rev":
"15eb85b8cb9d52cb79dc37dff7d2cfcd2400e778"}

[commit-bot: I haz the power, 2017-03-24 23:26:01]

Description was changed from

==========
Add operator<< to StyleDifference for debug logging.

Similar to http://crrev.com/2732643004. I wanted this while debugging animation
related style changes and thought it would be potentially useful for others
ongoing.

BUG=695125
==========

to

==========
Add operator<< to StyleDifference for debug logging.

Similar to http://crrev.com/2732643004. I wanted this while debugging animation
related style changes and thought it would be potentially useful for others
ongoing.

BUG=695125

Review-Url: https://codereview.chromium.org/2763643003
Cr-Commit-Position: refs/heads/master@{#459595}
Committed:
https://chromium.googlesource.com/chromium/src/+/15eb85b8cb9d52cb79dc37dff7d2...
==========

[commit-bot: I haz the power, 2017-03-24 23:26:02]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/15eb85b8cb9d52cb79dc37dff7d2...

[hayato, 2017-03-27 04:53:56]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2777803002/ by hayato@chromium.org.

The reason for reverting is: Consistent failure: webkit_unit_tests failing on
chromium.webkit/WebKit Android (Nexus4)

WebKit Android (Nexus4) [50 since first detection]
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Andr...:


The first failure:
-

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Andr...

Test output:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit...

C  169.736s Main  [FAIL] StyleDifferenceTest.StreamOutputAllFieldsMutated:
C  169.736s Main  [ RUN      ] StyleDifferenceTest.StreamOutputAllFieldsMutated
C  169.736s Main 
../../third_party/WebKit/Source/core/style/StyleDifferenceTest.cpp:40: Failure
C  169.736s Main  Value of: stringStream.str()
C  169.736s Main    Actual: "StyleDifference{layoutType=PositionedMovement,
paintInvalidationType=PaintInvalidationObject, recomputeOverflow=1,
visualRectUpdate=1,
propertySpecificDifferences=TransformChanged|ScrollAnchorDisablingPropertyChanged}"
C  169.736s Main  Expected: "StyleDifference{layoutType=PositionedMovement, "
"paintInvalidationType=PaintInvalidationObject, recomputeOverflow=1, "
"visualRectUpdate=1, " "propertySpecificDifferences=TransformChanged|"
"ScrollAnchorDisablingPropertyChanged|TransformChanged|"
"ScrollAnchorDisablingPropertyChanged}"
C  169.736s Main  Which is: "StyleDifference{layoutType=PositionedMovement,
paintInvalidationType=PaintInvalidationObject, recomputeOverflow=1,
visualRectUpdate=1,
propertySpecificDifferences=TransformChanged|ScrollAnchorDisablingPropertyChanged|TransformChanged|ScrollAnchorDisablingPropertyChanged}"
.