chrome/browser/android/vr_shell/ui_elements.cc - Issue 2777633003: Avoid duplicate math when computing VR scene hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/ui_elements.cc

Issue 2777633003: Avoid duplicate math when computing VR scene hierarchy. (Closed)

Patch Set: Rever the inheritable transform getter for now - we can make a struct-to-class change later if we w… Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/ui_elements.cc

diff --git a/chrome/browser/android/vr_shell/ui_elements.cc b/chrome/browser/android/vr_shell/ui_elements.cc

index 71e7b757f70dba0054c1893f7d29a71daea2c17a..c779d37ded8248002585e81569dc21c2bb76d446 100644

--- a/chrome/browser/android/vr_shell/ui_elements.cc

+++ b/chrome/browser/android/vr_shell/ui_elements.cc

@@ -64,10 +64,6 @@ const gvr::Mat4f& WorldRectangle::TransformMatrix() const {

return transform_.to_world;

}

-void WorldRectangle::SetTransform(const Transform& transform) {

- transform_ = transform;

gvr::Vec3f WorldRectangle::GetCenter() const {

const gvr::Vec3f kOrigin = {0.0f, 0.0f, 0.0f};

return MatrixVectorMul(transform_.to_world, kOrigin);