chrome/browser/android/vr_shell/ui_scene.h - Issue 2777633003: Avoid duplicate math when computing VR scene hierarchy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/ui_scene.h

Issue 2777633003: Avoid duplicate math when computing VR scene hierarchy. (Closed)

Patch Set: Rever the inheritable transform getter for now - we can make a struct-to-class change later if we w… Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/ui_scene.h

diff --git a/chrome/browser/android/vr_shell/ui_scene.h b/chrome/browser/android/vr_shell/ui_scene.h

index 4eef429f3374fc590c0108003ecaf7866047a1a1..4bcb6d88d29a490db659f71ee6a5720adfad48f4 100644

--- a/chrome/browser/android/vr_shell/ui_scene.h

+++ b/chrome/browser/android/vr_shell/ui_scene.h

@@ -20,7 +20,6 @@ namespace vr_shell {

class Animation;

struct ContentRectangle;

-struct Transform;

class UiScene {

public:

@@ -78,10 +77,7 @@ class UiScene {

bool GetWebVrRenderingEnabled() const;

private:

- void ApplyRecursiveTransforms(const ContentRectangle& element,

- Transform* transform,

- float* opacity,

- bool* lock_to_fov);

+ void ApplyRecursiveTransforms(ContentRectangle* element);

void ApplyDictToElement(const base::DictionaryValue& dict,

ContentRectangle* element);