Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2777543002: Merge "Updating :in-range should not rely on validation." to M58. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge "Updating :in-range should not rely on validation." to M58. m_validityIsDirty is not related to isInRange() and isOutOfRange(). This fixes sibling style invalidation using invalidation sets for :in-range and :out-of-range changes when value changes through setAttribute. R=tkent@chromium.org BUG=699884 Review-Url: https://codereview.chromium.org/2764023003 Cr-Commit-Position: refs/heads/master@{#458576} (cherry picked from commit df2ef06a75aae87d449e2f801e90fd418679871b) Review-Url: https://codereview.chromium.org/2777543002 . Cr-Commit-Position: refs/branch-heads/3029@{#404} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/660abd2962f7bf553dd7f4146f1ec5e5f1f168d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/in-range-pseudo.html View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
3 years, 9 months ago (2017-03-24 08:18:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
660abd2962f7bf553dd7f4146f1ec5e5f1f168d0.

Powered by Google App Engine
This is Rietveld 408576698