Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 2764023003: Updating :in-range should not rely on validation. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating :in-range should not rely on validation. m_validityIsDirty is not related to isInRange() and isOutOfRange(). This fixes sibling style invalidation using invalidation sets for :in-range and :out-of-range changes when value changes through setAttribute. R=tkent@chromium.org BUG=699884 Review-Url: https://codereview.chromium.org/2764023003 Cr-Commit-Position: refs/heads/master@{#458576} Committed: https://chromium.googlesource.com/chromium/src/+/df2ef06a75aae87d449e2f801e90fd418679871b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/in-range-pseudo.html View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
rune
ptal
3 years, 9 months ago (2017-03-21 17:45:03 UTC) #3
tkent
lgtm
3 years, 9 months ago (2017-03-21 22:00:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764023003/1
3 years, 9 months ago (2017-03-21 22:00:46 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 22:14:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df2ef06a75aae87d449e2f801e90...

Powered by Google App Engine
This is Rietveld 408576698