Report compile-time error on invalid constructors.

Report compile-time error on invalid constructors.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/62b39e746a53d91f8328e411d63b6a98c3afef6e

[ahe, 2017-03-24 07:35:06]

ahe@google.com changed reviewers:
+ karlklose@google.com, paulberry@google.com

[karlklose, 2017-03-24 08:54:08]

LGTM

https://codereview.chromium.org/2777533002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2777533002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1750: if (arguments ==
null) {
Could you move this code into a local function instead?

https://codereview.chromium.org/2777533002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_target.dart (right):

https://codereview.chromium.org/2777533002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_target.dart:576:
"${cls.superclass.name} has no constructor that takes zero"
'zero' -> 'no'?

[ahe, 2017-03-24 12:47:58]

Thank you, Karl!

https://codereview.chromium.org/2777533002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2777533002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1750: if (arguments ==
null) {
On 2017/03/24 08:54:08, karlklose wrote:
> Could you move this code into a local function instead?

Done.

https://codereview.chromium.org/2777533002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/kernel_target.dart (right):

https://codereview.chromium.org/2777533002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/kernel_target.dart:576:
"${cls.superclass.name} has no constructor that takes zero"
On 2017/03/24 08:54:08, karlklose wrote:
> 'zero' -> 'no'?

Done.

[ahe, 2017-03-24 13:11:38]

Description was changed from

==========
Report compile-time error on invalid constructors.
==========

to

==========
Report compile-time error on invalid constructors.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/62b39e746a53d91f8328e411d63b6a98c3afef6e
==========

[ahe, 2017-03-24 13:11:39]

Committed patchset #2 (id:20001) manually as
62b39e746a53d91f8328e411d63b6a98c3afef6e (presubmit successful).