Allow identical as a compile-time constant.

Allow identical as a compile-time constant.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/91e290b6100c9ea0e6dbbafc1af783dca1e439f8

[ahe, 2017-03-24 08:27:53]

ahe@google.com changed reviewers:
+ karlklose@google.com, paulberry@google.com

[karlklose, 2017-03-24 08:42:30]

LGTM

https://codereview.chromium.org/2770243002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2770243002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:522: if (!(receiver is
StaticAccessor &&
Maybe move the checks in l. 523-525 to a helper called 'isIdentical' and merge
the condition with l. 521.

[ahe, 2017-03-24 13:14:35]

Thank you, Karl!

https://codereview.chromium.org/2770243002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2770243002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:522: if (!(receiver is
StaticAccessor &&
On 2017/03/24 08:42:30, karlklose wrote:
> Maybe move the checks in l. 523-525 to a helper called 'isIdentical' and merge
> the condition with l. 521.

Done.

[ahe, 2017-03-24 13:43:06]

Description was changed from

==========
Allow identical as a compile-time constant.
==========

to

==========
Allow identical as a compile-time constant.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/91e290b6100c9ea0e6dbbafc1af783dca1e439f8
==========

[ahe, 2017-03-24 13:43:07]

Committed patchset #3 (id:40001) manually as
91e290b6100c9ea0e6dbbafc1af783dca1e439f8 (presubmit successful).