Report compile-time error on invalid constructors.

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.body_builder;
 
 import '../parser/parser.dart' show FormalParameterType, optional;
 
 import '../parser/error_kind.dart' show ErrorKind;
 
@@ skipping 1727 matching lines @@
   }
 
   @override
   void endNewExpression(Token token) {
     debugEvent("NewExpression");
     Token nameToken = token.next;
     Arguments arguments = pop();
     String name = pop();
     List<DartType> typeArguments = pop();
     var type = pop();
-    constantExpressionRequired = pop();
+    bool savedConstantExpressionRequired = pop();
+    try {
+      if (arguments == null) {

[karlklose, 2017/03/24 08:54:08]

Could you move this code into a local function instead?

[ahe, 2017/03/24 12:47:58]

Done.

+        push(buildCompileTimeError("No arguments.", nameToken.charOffset));
+        return;
+      }
 
-    if (arguments == null) {
-      push(buildCompileTimeError("No arguments.", nameToken.charOffset));
-      return;
+      if (typeArguments != null) {
+        assert(arguments.types.isEmpty);
+        arguments.types.addAll(typeArguments);
+      }
+
+      String errorName;
+      if (type is ClassBuilder) {
+        Builder b = type.findConstructorOrFactory(name);
+        Member target;
+        if (b == null) {
+          // Not found. Reported below.
+        } else if (b.isConstructor) {
+          if (type.isAbstract) {
+            // TODO(ahe): Generate abstract instantiation error.
+          } else {
+            target = b.target;
+          }
+        } else if (b.isFactory) {
+          target = getRedirectionTarget(b.target);
+          if (target == null) {
+            push(buildCompileTimeError(
+                "Cyclic definition of factory '${name}'.",
+                nameToken.charOffset));
+            return;
+          }
+        }
+        if (target is Constructor ||
+            (target is Procedure && target.kind == ProcedureKind.Factory)) {
+          push(buildStaticInvocation(target, arguments,
+              isConst: optional("const", token),
+              charOffset: nameToken.charOffset));
+          return;
+        } else {
+          errorName = debugName(type.name, name);
+        }
+      } else {
+        errorName = debugName(getNodeName(type), name);
+      }
+      errorName ??= name;
+      push(throwNoSuchMethodError(errorName, arguments, nameToken.charOffset));
+    } finally {
+      constantExpressionRequired = savedConstantExpressionRequired;
     }
-
-    if (typeArguments != null) {
-      assert(arguments.types.isEmpty);
-      arguments.types.addAll(typeArguments);
-    }
-
-    String errorName;
-    if (type is ClassBuilder) {
-      Builder b = type.findConstructorOrFactory(name);
-      Member target;
-      if (b == null) {
-        // Not found. Reported below.
-      } else if (b.isConstructor) {
-        if (type.isAbstract) {
-          // TODO(ahe): Generate abstract instantiation error.
-        } else {
-          target = b.target;
-        }
-      } else if (b.isFactory) {
-        target = getRedirectionTarget(b.target);
-        if (target == null) {
-          push(buildCompileTimeError(
-              "Cyclic definition of factory '${name}'.", nameToken.charOffset));
-          return;
-        }
-      }
-      if (target is Constructor ||
-          (target is Procedure && target.kind == ProcedureKind.Factory)) {
-        push(buildStaticInvocation(target, arguments,
-            isConst: optional("const", token),
-            charOffset: nameToken.charOffset));
-        return;
-      } else {
-        errorName = debugName(type.name, name);
-      }
-    } else {
-      errorName = debugName(getNodeName(type), name);
-    }
-    errorName ??= name;
-    push(throwNoSuchMethodError(errorName, arguments, nameToken.charOffset));
   }
 
   @override
   void endConstExpression(Token token) {
     debugEvent("endConstExpression");
     endNewExpression(token);
   }
 
   @override
   void endTypeArguments(int count, Token beginToken, Token endToken) {
@@ skipping 1042 matching lines @@
   } else if (node is PrefixBuilder) {
     return node.name;
   } else if (node is ThisAccessor) {
     return node.isSuper ? "super" : "this";
   } else if (node is BuilderAccessor) {
     return node.plainNameForRead;
   } else {
     return internalError("Unhandled: ${node.runtimeType}");
   }
 }