Make custom GREYAction methods Chromium C-Style.

Make custom GREYAction methods Chromium C-Style.

These methods are C-Style, so they should start with a capital
letter.

BUG=683432
Review-Url: https://codereview.chromium.org/2777463002
Cr-Commit-Position: refs/heads/master@{#459462}
Committed: https://chromium.googlesource.com/chromium/src/+/e07705dc86eaaf8473e7e9727a0817db46f40d22

[baxley, 2017-03-24 15:32:23]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-03-24 16:24:32]

lgtm

https://codereview.chromium.org/2777463002/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/context_menu/context_menu_egtest.mm (right):

https://codereview.chromium.org/2777463002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/context_menu/context_menu_egtest.mm:83: elementId, true /*
menu should appear */)];
Do you want to fix valriable name? s/elementId/element_id

https://codereview.chromium.org/2777463002/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/web_view_actions.h (right):

https://codereview.chromium.org/2777463002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_actions.h:20: id<GREYAction>
WebViewVerifiedActionOnElement(WebState* state,
Do we need to prefix all actions with WebView? We don't prefix matchers AFAIK

[baxley, 2017-03-24 16:48:08]

https://codereview.chromium.org/2777463002/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/context_menu/context_menu_egtest.mm (right):

https://codereview.chromium.org/2777463002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/context_menu/context_menu_egtest.mm:83: elementId, true /*
menu should appear */)];
On 2017/03/24 16:24:31, Eugene But wrote:
> Do you want to fix valriable name? s/elementId/element_id

Done.

https://codereview.chromium.org/2777463002/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/web_view_actions.h (right):

https://codereview.chromium.org/2777463002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_actions.h:20: id<GREYAction>
WebViewVerifiedActionOnElement(WebState* state,
On 2017/03/24 16:24:31, Eugene But wrote:
> Do we need to prefix all actions with WebView? We don't prefix matchers AFAIK

Probably not. I have a bug I'm looking at to get rid of matchers that wait, so
most (all?) of these would go away. I'll leave this as is, and choose better
names when they move to ChromeEarlGrey[UI]

[baxley, 2017-03-24 16:48:53]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-03-24 16:48:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2777463002/#ps40001
(title: "more c-style")

[commit-bot: I haz the power, 2017-03-24 16:49:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 17:04:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490374133786270,
"parent_rev": "0b9720c2eb9ba96fb1ca3a22a721ae0bd0b6a25a", "commit_rev":
"e07705dc86eaaf8473e7e9727a0817db46f40d22"}

[commit-bot: I haz the power, 2017-03-24 17:05:11]

Description was changed from

==========
Make custom GREYAction methods Chromium C-Style.

These methods are C-Style, so they should start with a capital
letter.

BUG=683432
==========

to

==========
Make custom GREYAction methods Chromium C-Style.

These methods are C-Style, so they should start with a capital
letter.

BUG=683432

Review-Url: https://codereview.chromium.org/2777463002
Cr-Commit-Position: refs/heads/master@{#459462}
Committed:
https://chromium.googlesource.com/chromium/src/+/e07705dc86eaaf8473e7e9727a08...
==========

[commit-bot: I haz the power, 2017-03-24 17:05:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e07705dc86eaaf8473e7e9727a08...