Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: ios/web/public/test/earl_grey/web_view_actions.mm

Issue 2777463002: Make custom GREYAction methods Chromium C-Style. (Closed)
Patch Set: more c-style Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/public/test/earl_grey/web_view_actions.h ('k') | ios/web/shell/test/context_menu_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/test/earl_grey/web_view_actions.mm
diff --git a/ios/web/public/test/earl_grey/web_view_actions.mm b/ios/web/public/test/earl_grey/web_view_actions.mm
index e86923475200caca43b09a81def4bfc202564407..0d0b0647b7d2cfe03f917e339eed6c14bb792719 100644
--- a/ios/web/public/test/earl_grey/web_view_actions.mm
+++ b/ios/web/public/test/earl_grey/web_view_actions.mm
@@ -110,7 +110,7 @@ void RemoveVerifierForElementWithId(web::WebState* web_state,
}
// Returns a no element found error.
-id<GREYAction> webViewElementNotFound(const std::string& element_id) {
+id<GREYAction> WebViewElementNotFound(const std::string& element_id) {
NSString* description = [NSString
stringWithFormat:@"Couldn't locate a bounding rect for element_id %s; "
@"either it isn't there or it has no area.",
@@ -131,7 +131,7 @@ id<GREYAction> webViewElementNotFound(const std::string& element_id) {
namespace web {
-id<GREYAction> webViewVerifiedActionOnElement(WebState* state,
+id<GREYAction> WebViewVerifiedActionOnElement(WebState* state,
id<GREYAction> action,
const std::string& element_id) {
NSString* action_name =
@@ -198,13 +198,13 @@ id<GREYAction> webViewVerifiedActionOnElement(WebState* state,
performBlock:verified_tap];
}
-id<GREYAction> webViewLongPressElementForContextMenu(
+id<GREYAction> WebViewLongPressElementForContextMenu(
WebState* state,
const std::string& element_id,
bool triggers_context_menu) {
CGRect rect = web::test::GetBoundingRectOfElementWithId(state, element_id);
if (CGRectIsEmpty(rect)) {
- return webViewElementNotFound(element_id);
+ return WebViewElementNotFound(element_id);
}
CGPoint point = CGPointMake(CGRectGetMidX(rect), CGRectGetMidY(rect));
id<GREYAction> longpress =
@@ -212,15 +212,15 @@ id<GREYAction> webViewLongPressElementForContextMenu(
if (triggers_context_menu) {
return longpress;
}
- return webViewVerifiedActionOnElement(state, longpress, element_id);
+ return WebViewVerifiedActionOnElement(state, longpress, element_id);
}
-id<GREYAction> webViewTapElement(WebState* state,
+id<GREYAction> WebViewTapElement(WebState* state,
const std::string& element_id) {
CGRect rect = web::test::GetBoundingRectOfElementWithId(state, element_id);
CGPoint point = CGPointMake(CGRectGetMidX(rect), CGRectGetMidY(rect));
- return CGRectIsEmpty(rect) ? webViewElementNotFound(element_id)
- : webViewVerifiedActionOnElement(
+ return CGRectIsEmpty(rect) ? WebViewElementNotFound(element_id)
+ : WebViewVerifiedActionOnElement(
state, grey_tapAtPoint(point), element_id);
}
« no previous file with comments | « ios/web/public/test/earl_grey/web_view_actions.h ('k') | ios/web/shell/test/context_menu_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698