Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1584)

Unified Diff: test/inspector/testcfg.py

Issue 2777413005: [inspector] correctly test more variants. (Closed)
Patch Set: [inspector] correctly test more variants. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/inspector/inspector-test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/testcfg.py
diff --git a/test/inspector/testcfg.py b/test/inspector/testcfg.py
index 23d5aac85404a571ea0b79b9bc5e96222a1ec7d4..8dea3c96e87e8e5c0d143f27462c315db02575c9 100644
--- a/test/inspector/testcfg.py
+++ b/test/inspector/testcfg.py
@@ -40,14 +40,14 @@ class InspectorProtocolTestSuite(testsuite.TestSuite):
def GetFlagsForTestCase(self, testcase, context):
source = self.GetSourceForTest(testcase)
+ flags = [] + context.mode_flags
flags_match = re.findall(FLAGS_PATTERN, source)
- flags = []
for match in flags_match:
flags += match.strip().split()
testname = testcase.path.split(os.path.sep)[-1]
testfilename = os.path.join(self.root, testcase.path + self.suffix())
protocoltestfilename = os.path.join(self.root, PROTOCOL_TEST_JS)
- return [ protocoltestfilename, testfilename ] + flags
+ return testcase.flags + flags + [ protocoltestfilename, testfilename ]
def GetSourceForTest(self, testcase):
filename = os.path.join(self.root, testcase.path + self.suffix())
« no previous file with comments | « test/inspector/inspector-test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698