Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2777193002: Enable SwiftShader fallback on desktop Linux. (Closed)

Created:
3 years, 9 months ago by capn
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable SwiftShader fallback on desktop Linux. SwiftShader is an OpenGL ES implementation which runs on the CPU, and is used as a fallback for WebGL support when the GPU or its driver have been blacklisted. It has been added to the Chrome installer for Windows in https://codereview.chromium.org/2715563002/ This CL enables the integration in Chromium on Linux. BUG=160392 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2777193002 Cr-Commit-Position: refs/heads/master@{#463872} Committed: https://chromium.googlesource.com/chromium/src/+/d85baf0b71c69bbd181aaefc8a803611e03c8eed

Patch Set 1 #

Patch Set 2 : Exclude chromeos #

Patch Set 3 : Update Linux expectations #

Patch Set 4 : Restrict to x86 #

Patch Set 5 : Rebase #

Patch Set 6 : Ignore accelerated canvas preliminary blacklisting. #

Patch Set 7 : Allow GPU process when accelerated 2D canvas blacklisted. #

Patch Set 8 : Adjust GPU process expectations for Linux #

Patch Set 9 : If GpuAccessAllowed() returns true, reason is empty #

Patch Set 10 : Preserve GPU vendor/device IDs. #

Patch Set 11 : Fix UpdateActiveGpu unit test. #

Patch Set 12 : Fix UpdateActiveGpu again. #

Patch Set 13 : Enable SwiftShader fallback on desktop Linux. #

Patch Set 14 : Disable SwiftShader for active GPU tests. #

Patch Set 15 : Mark all GPUs inactive. #

Patch Set 16 : Fix compile. #

Patch Set 17 : Fix new UpdateActiveGpu expectation. #

Total comments: 2

Patch Set 18 : Info collected successfully. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -43 lines) Patch
M chrome/tools/build/linux/FILES.cfg View 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +25 lines, -3 lines 1 comment Download
M content/browser/gpu/gpu_data_manager_impl_private_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 8 chunks +42 lines, -24 lines 1 comment Download
M content/test/gpu/gpu_tests/gpu_process_expectations.py View 1 2 3 4 5 6 7 1 chunk +6 lines, -7 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_process_integration_test.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +8 lines, -8 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 106 (93 generated)
capn
FYI
3 years, 8 months ago (2017-03-29 16:59:31 UTC) #15
capn
PTAL
3 years, 8 months ago (2017-04-08 03:33:24 UTC) #76
capn
Updated to not leave any GPU as active when using SwiftShader. PTAL.
3 years, 8 months ago (2017-04-10 21:14:33 UTC) #88
capn
Updated to not leave any GPU as active when using SwiftShader. PTAL.
3 years, 8 months ago (2017-04-10 21:18:06 UTC) #90
piman
https://codereview.chromium.org/2777193002/diff/320001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/2777193002/diff/320001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode1278 content/browser/gpu/gpu_data_manager_impl_private.cc:1278: // to prevent attempts to use them (crbug.com/702417). Could ...
3 years, 8 months ago (2017-04-10 23:58:55 UTC) #91
capn
On 2017/04/10 at 23:58:55, piman wrote: > https://codereview.chromium.org/2777193002/diff/320001/content/browser/gpu/gpu_data_manager_impl_private.cc > File content/browser/gpu/gpu_data_manager_impl_private.cc (right): > > https://codereview.chromium.org/2777193002/diff/320001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode1278 ...
3 years, 8 months ago (2017-04-11 02:26:36 UTC) #94
capn
Any chance this could still make it into M59? We're trying to coordinate having SwiftShader ...
3 years, 8 months ago (2017-04-11 20:53:45 UTC) #97
piman
LGTM if you're blocked, but please strongly consider adding a unit test as a follow ...
3 years, 8 months ago (2017-04-11 21:43:38 UTC) #98
Ken Russell (switch to Gerrit)
Sorry for the delay reviewing this. LGTM. Two minor comments. https://codereview.chromium.org/2777193002/diff/340001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/2777193002/diff/340001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode1281 ...
3 years, 8 months ago (2017-04-11 22:03:45 UTC) #99
Michael Moss
lgtm
3 years, 8 months ago (2017-04-12 00:32:44 UTC) #100
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777193002/340001
3 years, 8 months ago (2017-04-12 00:44:38 UTC) #102
capn
On 2017/04/11 at 22:03:45, kbr wrote: > Sorry for the delay reviewing this. LGTM. Two ...
3 years, 8 months ago (2017-04-12 00:56:15 UTC) #103
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 01:18:10 UTC) #106
Message was sent while issue was closed.
Committed patchset #18 (id:340001) as
https://chromium.googlesource.com/chromium/src/+/d85baf0b71c69bbd181aaefc8a80...

Powered by Google App Engine
This is Rietveld 408576698