Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 2777123002: [Merge to M-58] Fix Password bubble title misalignment. (Closed)

Created:
3 years, 9 months ago by dvadym
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to M-58] Fix Password bubble title misalignment. This CL sets correct margins for Password Bubbles titles. Screenshots with explanation what's wrong and how bubbles look like with this CL are attached on the bug. BUG=704575 Review-Url: https://codereview.chromium.org/2773733002 Cr-Commit-Position: refs/heads/master@{#459418} (cherry picked from commit bf765c663d54787ab8dc3bb1b8c1748aab1d0eea) Review-Url: https://codereview.chromium.org/2777123002 . Cr-Commit-Position: refs/branch-heads/3029@{#424} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/623dc2bca68212e0f7e4617e84585a74fe63c7bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dvadym
3 years, 9 months ago (2017-03-27 11:49:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
623dc2bca68212e0f7e4617e84585a74fe63c7bc.

Powered by Google App Engine
This is Rietveld 408576698