Fix Password bubble title misalignment.

Fix Password bubble title misalignment.

This CL sets correct margins for Password Bubbles titles. Screenshots with explanation what's wrong and how bubbles look like with this CL are attached on the bug.

BUG=704575
Review-Url: https://codereview.chromium.org/2773733002
Cr-Commit-Position: refs/heads/master@{#459418}
Committed: https://chromium.googlesource.com/chromium/src/+/bf765c663d54787ab8dc3bb1b8c1748aab1d0eea

[dvadym, 2017-03-23 16:12:21]

Description was changed from

==========
Fix Password bubble title misalignment

BUG=704575
==========

to

==========
Fix Password bubble title misalignment.

Screenshots with explanation what should be fixed are on the bug.

BUG=704575
==========

[dvadym, 2017-03-23 16:20:24]

dvadym@chromium.org changed reviewers:
+ vasilii@chromium.org

[dvadym, 2017-03-23 16:20:24]

Hi Vasilii,

Could you please review this CL?

Regards,
Vadym

[dvadym, 2017-03-23 16:25:09]

Description was changed from

==========
Fix Password bubble title misalignment.

Screenshots with explanation what should be fixed are on the bug.

BUG=704575
==========

to

==========
Fix Password bubble title misalignment.

This CL sets correct margins for Password Bubbles titles. Screenshots with
explanation what's wrong and how bubbles look like with this CL are attached on
the bug.

BUG=704575
==========

[vasilii, 2017-03-23 17:51:27]

lgtm

https://codereview.chromium.org/2773733002/diff/1/chrome/browser/ui/views/pas...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right):

https://codereview.chromium.org/2773733002/diff/1/chrome/browser/ui/views/pas...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:771: const int
side_margin = margins().left();
Please add a comment why it's here.

[dvadym, 2017-03-24 13:20:43]

Thanks for review Vasilii! Please take a look at Mac fix.

https://codereview.chromium.org/2773733002/diff/1/chrome/browser/ui/views/pas...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right):

https://codereview.chromium.org/2773733002/diff/1/chrome/browser/ui/views/pas...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:771: const int
side_margin = margins().left();
On 2017/03/23 17:51:27, vasilii wrote:
> Please add a comment why it's here.

Done.

[vasilii, 2017-03-24 13:23:30]

lgtm

https://codereview.chromium.org/2773733002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right):

https://codereview.chromium.org/2773733002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:771: // Set
title margins to make the title and the content to be left aligned.
to make the title and the content left aligned.

[dvadym, 2017-03-24 13:32:34]

Thanks for review Vasilii!

https://codereview.chromium.org/2773733002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc (right):

https://codereview.chromium.org/2773733002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc:771: // Set
title margins to make the title and the content to be left aligned.
On 2017/03/24 13:23:30, vasilii wrote:
> to make the title and the content left aligned.

Done.

[dvadym, 2017-03-24 13:33:01]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 13:33:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 14:18:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 14:18:39]

Dry run: This issue passed the CQ dry run.

[dvadym, 2017-03-24 14:19:07]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2017-03-24 14:19:07]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/2773733002/#ps60001
(title: "Fix comment")

[commit-bot: I haz the power, 2017-03-24 14:19:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 14:26:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490365147587720,
"parent_rev": "9e42572a191d565d3cdf8650e88c4971a1b6441c", "commit_rev":
"bf765c663d54787ab8dc3bb1b8c1748aab1d0eea"}

[commit-bot: I haz the power, 2017-03-24 14:27:00]

Description was changed from

==========
Fix Password bubble title misalignment.

This CL sets correct margins for Password Bubbles titles. Screenshots with
explanation what's wrong and how bubbles look like with this CL are attached on
the bug.

BUG=704575
==========

to

==========
Fix Password bubble title misalignment.

This CL sets correct margins for Password Bubbles titles. Screenshots with
explanation what's wrong and how bubbles look like with this CL are attached on
the bug.

BUG=704575

Review-Url: https://codereview.chromium.org/2773733002
Cr-Commit-Position: refs/heads/master@{#459418}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf765c663d54787ab8dc3bb1b8c1...
==========

[commit-bot: I haz the power, 2017-03-24 14:27:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bf765c663d54787ab8dc3bb1b8c1...