Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2777103003: Turning ui/events/ipc into a source_set (Closed)

Created:
3 years, 9 months ago by mfomitchev
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Turning ui/events/ipc into a source_set There's no good reason for ui/events/ipc to be a component. BUG=686865 Review-Url: https://codereview.chromium.org/2777103003 Cr-Commit-Position: refs/heads/master@{#460153} Committed: https://chromium.googlesource.com/chromium/src/+/3249950eb5a68320b971ec02e537c338be7f3a9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -39 lines) Patch
M ui/events/ipc/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
D ui/events/ipc/events_ipc_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits_macros.h View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
mfomitchev
+tdresser for owner review +tsepez for security review
3 years, 9 months ago (2017-03-28 02:11:02 UTC) #6
tdresser
LGTM
3 years, 8 months ago (2017-03-28 13:15:53 UTC) #7
Tom Sepez
OWNERS LGTM
3 years, 8 months ago (2017-03-28 16:50:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2777103003/1
3 years, 8 months ago (2017-03-28 17:20:07 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:26:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3249950eb5a68320b971ec02e537...

Powered by Google App Engine
This is Rietveld 408576698