Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2670)

Unified Diff: base/trace_event/memory_dump_request_args.h

Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message (Closed)
Patch Set: Readd the extra_process_dump map Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_request_args.h
diff --git a/base/trace_event/memory_dump_request_args.h b/base/trace_event/memory_dump_request_args.h
index a8b3f423cad37f4aaaac3b9f395e4f20b509a65a..ed77fbe3de2c2b13df6c73e69abb5ae339a1deb2 100644
--- a/base/trace_event/memory_dump_request_args.h
+++ b/base/trace_event/memory_dump_request_args.h
@@ -14,6 +14,7 @@
#include "base/base_export.h"
#include "base/callback.h"
+#include "base/optional.h"
#include "base/process/process_handle.h"
namespace base {
@@ -98,10 +99,17 @@ struct MemoryDumpCallbackResult {
std::map<ProcessId, OSMemDump> extra_processes_dump;
MemoryDumpCallbackResult();
+ MemoryDumpCallbackResult(const MemoryDumpCallbackResult&);
~MemoryDumpCallbackResult();
};
-using MemoryDumpCallback = Callback<void(uint64_t dump_guid, bool success)>;
+using GlobalMemoryDumpCallback =
+ Callback<void(uint64_t dump_guid, bool success)>;
+
+using ProcessMemoryDumpCallback =
+ Callback<void(uint64_t dump_guid,
+ bool success,
+ const base::Optional<MemoryDumpCallbackResult>& result)>;
Primiano Tucci (use gerrit) 2017/04/07 15:31:36 nit: no need for base:: this is already in "namesp
fmeawad 2017/04/10 20:20:19 Done.
BASE_EXPORT const char* MemoryDumpTypeToString(const MemoryDumpType& dump_type);

Powered by Google App Engine
This is Rietveld 408576698