[Memory UMA] Return a memory summary struct with the ack message

base/trace_event/memory_dump_request_args.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TRACE_EVENT_MEMORY_DUMP_REQUEST_ARGS_H_
 #define BASE_TRACE_EVENT_MEMORY_DUMP_REQUEST_ARGS_H_
 
 // This file defines the types and structs used to issue memory dump requests.
 // These are also used in the IPCs for coordinating inter-process memory dumps.
 
 #include <stdint.h>
 #include <map>
 #include <string>
 
 #include "base/base_export.h"
 #include "base/callback.h"
+#include "base/optional.h"
 #include "base/process/process_handle.h"
 
 namespace base {
 namespace trace_event {
 
 // Captures the reason why a memory dump is being requested. This is to allow
 // selective enabling of dumps, filtering and post-processing. Important: this
 // must be kept consistent with
 // services/resource_coordinator/public/cpp/memory/memory_infra_traits.cc.
 enum class MemoryDumpType {
@@ skipping 44 matching lines @@
 // providers. Dump providers are expected to read the args for creating dumps.
 struct MemoryDumpArgs {
   // Specifies how detailed the dumps should be.
   MemoryDumpLevelOfDetail level_of_detail;
 };
 
 // TODO(hjd): Not used yet, see crbug.com/703184
 // Summarises information about memory use as seen by a single process.
 // This information will eventually be passed to a service to be colated
 // and reported.
 struct MemoryDumpCallbackResult {

[Primiano Tucci (use gerrit), 2017/04/07 15:31:36]

I think you now need BASE_EXPORT here.

The bots are red with

memory_instrumentation.mojom.obj : error LNK2001: unresolved external symbol
"public: __cdecl
base::trace_event::MemoryDumpCallbackResult::MemoryDumpCallbackResult(void)"
(??0MemoryDumpCallbackResult@trace_event@base@@QEAA@XZ)

Which suggests that the new const constructor now requires actual code to be
exported by base in component builds.

[fmeawad, 2017/04/10 20:20:19]

Done.

   struct OSMemDump {
     uint32_t resident_set_kb = 0;
   };
   struct ChromeMemDump {
     uint32_t malloc_total_kb = 0;
     uint32_t partition_alloc_total_kb = 0;
     uint32_t blink_gc_total_kb = 0;
     uint32_t v8_total_kb = 0;
   };
 
   // These are for the current process.
   OSMemDump os_dump;
   ChromeMemDump chrome_dump;
 
   // In some cases, OS stats can only be dumped from a privileged process to
   // get around to sandboxing/selinux restrictions (see crbug.com/461788).
   std::map<ProcessId, OSMemDump> extra_processes_dump;
 
   MemoryDumpCallbackResult();
+  MemoryDumpCallbackResult(const MemoryDumpCallbackResult&);
   ~MemoryDumpCallbackResult();
 };
 
-using MemoryDumpCallback = Callback<void(uint64_t dump_guid, bool success)>;
+using GlobalMemoryDumpCallback =
+    Callback<void(uint64_t dump_guid, bool success)>;
+
+using ProcessMemoryDumpCallback =
+    Callback<void(uint64_t dump_guid,
+                  bool success,
+                  const base::Optional<MemoryDumpCallbackResult>& result)>;

[Primiano Tucci (use gerrit), 2017/04/07 15:31:36]

nit: no need for base:: this is already in "namespace base"

[fmeawad, 2017/04/10 20:20:19]

Done.

 
 BASE_EXPORT const char* MemoryDumpTypeToString(const MemoryDumpType& dump_type);
 
 BASE_EXPORT MemoryDumpType StringToMemoryDumpType(const std::string& str);
 
 BASE_EXPORT const char* MemoryDumpLevelOfDetailToString(
     const MemoryDumpLevelOfDetail& level_of_detail);
 
 BASE_EXPORT MemoryDumpLevelOfDetail
 StringToMemoryDumpLevelOfDetail(const std::string& str);
 
 }  // namespace trace_event
 }  // namespace base
 
 #endif  // BASE_TRACE_EVENT_MEMORY_DUMP_REQUEST_ARGS_H_