services/resource_coordinator/memory/coordinator/coordinator_impl.h - Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/memory/coordinator/coordinator_impl.h

Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message (Closed)

Patch Set: Readd the extra_process_dump map Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/memory_dump_request_args.h ('K') | « content/browser/tracing/memory_tracing_browsertest.cc ('k') | services/resource_coordinator/memory/coordinator/coordinator_impl.cc » ('j') | services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/memory/coordinator/coordinator_impl.h

diff --git a/services/resource_coordinator/memory/coordinator/coordinator_impl.h b/services/resource_coordinator/memory/coordinator/coordinator_impl.h

index b4abc4d6a5856508c43bb1ebc1ddaae387098bad..8281c41204b62ecc830c5d36fb1c362f31dea45d 100644

--- a/services/resource_coordinator/memory/coordinator/coordinator_impl.h

+++ b/services/resource_coordinator/memory/coordinator/coordinator_impl.h

@@ -66,7 +66,9 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {

void OnProcessMemoryDumpResponse(

mojom::ProcessLocalDumpManager* process_manager,

uint64_t dump_guid,

- bool success);

+ bool success,

+ const base::Optional<base::trace_event::MemoryDumpCallbackResult>&

+ result);

Primiano Tucci (use gerrit) 2017/04/07 15:31:37 you can omit the argument name ("result") to keep

void PerformNextQueuedGlobalMemoryDump();

void FinalizeGlobalMemoryDumpIfAllManagersReplied();