services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h - Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

Issue 2777093009: [Memory UMA] Return a memory summary struct with the ack message (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/resource_coordinator/memory/coordinator/coordinator_impl_unittest.cc ('k') | services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

diff --git a/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

index 17b995a29e8fdcec4912b0e53d03710670b2c04b..ccff7191f6cde6b194b17d058d22e4396b696166 100644

--- a/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

+++ b/services/resource_coordinator/public/cpp/memory/memory_dump_manager_delegate_impl.h

@@ -60,7 +60,7 @@ class MemoryDumpManagerDelegateImpl

// The base::trace_event::MemoryDumpManager calls this.

void RequestGlobalMemoryDump(

const base::trace_event::MemoryDumpRequestArgs& args,

- const base::trace_event::MemoryDumpCallback& callback) override;

+ const base::trace_event::GlobalMemoryDumpCallback& callback) override;

Config config() { return config_; }

void SetAsNonCoordinatorForTesting();

@@ -76,7 +76,7 @@ class MemoryDumpManagerDelegateImpl

// A proxy callback for updating |pending_memory_dump_guid_|.

void MemoryDumpCallbackProxy(

- const base::trace_event::MemoryDumpCallback& callback,

+ const base::trace_event::GlobalMemoryDumpCallback& callback,

uint64_t dump_guid,

bool success);